Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_tar, pkg_zip: improve support for long paths on Windows #672

Merged
merged 2 commits into from Feb 14, 2023
Merged

pkg_tar, pkg_zip: improve support for long paths on Windows #672

merged 2 commits into from Feb 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2023

This commit updates pkg_zip to, when running on Windows, convert zip files' input paths to extended-length paths by (1) making them absolute and then (2) prepending with \\?\.

This commit updates `pkg_zip` to, when running on Windows, convert zip
files' input paths to extended-length paths by (1) making them absolute
and then (2) prepending with `\\?\`.
@ghost ghost requested review from aiuto and nacl as code owners February 13, 2023 21:35
@ghost ghost changed the title pkg_zip: improve support for long paths on Windows pkg_tar, pkg_zip: improve support for long paths on Windows Feb 13, 2023
@aiuto
Copy link
Collaborator

aiuto commented Feb 14, 2023

Thanks for doing this.

@aiuto aiuto merged commit f9cf795 into bazelbuild:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants