Add support for setting uid/gid from pkg_attributes #671
Conversation
There was a problem hiding this comment.
Thanks for the patch! Below are things I noticed, but unfortunately the manifest format changed recently, so there's a number of merge conflicts.
Some things I wonder about outside of the motivating use case (discussion in #670):
- What about
pkg_rpm? It's fine not to include it, as it might be a little complicated and/or not possible. - Perhaps
uid/gidshould not be named inpkg_attributes? An alternative interface design would be to detect ifuser/groupare ints, and then convert that touid/gidon the backend. WDYT?
This enables the user to produce identical tarballs to fix bazelbuild#670 Signed-off-by: Austin Schuh <[email protected]>
|
Ok, I think this now works again. I don't know how to run the RPM tests. They appear to be disabled locally. If you can give me a hint, I can see what I can do. |
|
@nacl I think it is blocked on you resolving a comment. |
|
Ping, @nacl , any additional feedback? |
There was a problem hiding this comment.
Sorry for the delays on this. I got a bit stuck on some internal stuff and only recently got a chance to refocus.
This seems fine, but I think the docs could use a slight adjustment. See below WRT the RPM tests.
Ok, I think this now works again. I don't know how to run the RPM tests. They appear to be disabled locally. If you can give me a hint, I can see what I can do.
The RPM tests require external RPM tooling (rpm and rpmbuild). On macOS, you can get a recent copy of these from homebrew. On Linux, you can use your local package manager. Either should work.
Unfortunately, RPM packaging is tricky and a portable toolchain setup is difficult to make.
LMK if you have any further issues. If you're having issues with this, the documentation can be updated and this investigation can be added to the backlog. Intuitively, it may not make sense for RPMs (and Debs) to support numeric ids.
|
Friendly ping. This should get merged, can we come to closure on the last few nits? |
|
Sorry for the long delay... I went from having time to not having time really fast. |
This enables the user to produce identical tarballs to fix #670 by adding a uid/gid option to pkg_attributes.