Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_deb supports license attribute #651

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Dec 19, 2022

This change adds an optional attribute to pkg_deb called license for providing a short license description of the packaged code to the artifact meta info. E.g.,

pkg_deb(
  ...
  license = "BSD-3-Clause",
  ...
)

$ dpkg -I foo.deb
...
 License: BSD-3-Clause
...

Closes #650.

Signed-off-by: Nils Semmelrock [email protected]

@google-cla
Copy link

google-cla bot commented Dec 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nstng
Copy link
Contributor Author

nstng commented Dec 19, 2022

First PR here :) I did not find special contributor guidelines (apart from the CLA - which is in progress). Let me know if I missed something.
Unsure about adding this change to the docs - I only see 0.8.0 docs, but no upcoming/0.9.0 docs where I could add this.

@aiuto
Copy link
Collaborator

aiuto commented Dec 19, 2022

CLA https://cla.developers.google.com/

Don't worry about the docs. I do those periodically. But, if you want to try it, do what is in doc_build/BUILD

bazel build //doc_build:reference
cp bazel-bin/doc_build/reference.md docs/latest.md
git commit -m 'update docs' docs/latest.md

tests/deb/pkg_deb_test.py Outdated Show resolved Hide resolved
docs/pkg_deb.md Outdated Show resolved Hide resolved
@nstng nstng force-pushed the support_license_attribute branch from b7e9577 to 007f9ec Compare December 19, 2022 17:43
@nstng
Copy link
Contributor Author

nstng commented Dec 19, 2022

CLA https://cla.developers.google.com/

In progress - I need to do this via corporate (I don't expect issues, I just have to wait for approval)

Don't worry about the docs. I do those periodically. But, if you want to try it, do what is in doc_build/BUILD

bazel build //doc_build:reference
cp bazel-bin/doc_build/reference.md docs/latest.md
git commit -m 'update docs' docs/latest.md

added second commit with generated docs

@aiuto
Copy link
Collaborator

aiuto commented Dec 20, 2022

Great. I'll wait for the CLA. Ping this PR when you are ready and I can merge.

@nstng nstng force-pushed the support_license_attribute branch 2 times, most recently from 30f4cc7 to 34fd742 Compare January 10, 2023 10:54
nstng added 2 commits January 10, 2023 11:57
* optional attribute to add a short license description to the meta data of created debian artifacts

Signed-off-by: Nils Semmelrock <[email protected]>
Signed-off-by: Nils Semmelrock <[email protected]>
@nstng nstng force-pushed the support_license_attribute branch from 34fd742 to 7f86b78 Compare January 10, 2023 10:58
@nstng
Copy link
Contributor Author

nstng commented Jan 10, 2023

Hi @aiuto, got my CLA finally setup :)
PR is rebased and ready-for-review. (sry for the multiple rebases - had to change my author email)

@aiuto aiuto merged commit 52ed3ef into bazelbuild:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_deb license attribute is not supported
2 participants