Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly store implicit parent directories in zip files #640

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 23, 2022

Tooling in the Java world (and likely elsewhere) has come to depend on all directories implicilty present as parent directories of files to be listed explicitly as a member of a ZIP file.

Fixes #638
Fixes #622

@fmeum fmeum requested review from aiuto and nacl as code owners November 23, 2022 12:45
@fmeum
Copy link
Contributor Author

fmeum commented Nov 23, 2022

FYI @guw

@fmeum fmeum force-pushed the create-parent-directories branch from f50cdc7 to c93c4d3 Compare November 23, 2022 12:47
pkg/private/zip/build_zip.py Outdated Show resolved Hide resolved
Tooling in the Java world (and likely elsewhere) has come to depend on
all directories implicilty present as parent directories of files to be
listed explicitly as a member of a ZIP file.
@fmeum fmeum force-pushed the create-parent-directories branch from c93c4d3 to d2f51aa Compare November 23, 2022 13:03
Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few nits.

pkg/private/zip/build_zip.py Outdated Show resolved Hide resolved
pkg/private/zip/build_zip.py Outdated Show resolved Hide resolved
pkg/private/zip/build_zip.py Show resolved Hide resolved
@fmeum
Copy link
Contributor Author

fmeum commented Nov 23, 2022

I am now using your approach to fix the mode argument type.

@aiuto aiuto merged commit 8e65d2f into bazelbuild:main Nov 24, 2022
@fmeum fmeum deleted the create-parent-directories branch November 24, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZIP files contain no directory entries Directory entries not added to zip contents
2 participants