Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tree artifact support to pkg_zip #537

Merged
merged 27 commits into from
Apr 1, 2022
Merged

Add tree artifact support to pkg_zip #537

merged 27 commits into from
Apr 1, 2022

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Feb 12, 2022 •
edited
Loading

Fixes #309

It is a largish change only because I refactored biuld_zip from free methods to a class.
That made it easier to pass around the default mode and timestamp.

@aiuto aiuto requested a review from nacl as a code owner February 12, 2022 16:38
@aiuto aiuto requested a review from jylinv0 February 12, 2022 16:41
@aiuto aiuto mentioned this pull request Feb 12, 2022
Closed
@aiuto aiuto mentioned this pull request Mar 3, 2022
Closed
@aiuto aiuto added the P1 An issue that must be resolved. Must have an assignee label Mar 16, 2022
nacl
nacl approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@nacl nacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.

This change was a little hard to read: the creation of the ZipWriter class probably should have been done separately from the TreeArtifact integration so that it was more obvious what changed in add_manifest_entry.

pkg/private/zip/build_zip.py Outdated Show resolved Hide resolved
tests/zip/BUILD Outdated Show resolved Hide resolved
pkg/private/zip/build_zip.py Show resolved Hide resolved
pkg/private/zip/build_zip.py Show resolved Hide resolved
pkg/private/zip/build_zip.py Show resolved Hide resolved
pkg/private/zip/build_zip.py Show resolved Hide resolved
pkg/private/zip/build_zip.py Show resolved Hide resolved
pkg/private/zip/build_zip.py Outdated Show resolved Hide resolved
@aiuto
Copy link
Collaborator Author

aiuto commented Apr 1, 2022

LGTM modulo comments.

This change was a little hard to read: the creation of the ZipWriter class probably should have been done separately from the TreeArtifact integration so that it was more obvious what changed in add_manifest_entry.

Yes. This ended up as to PRs. I should have made it 3.

@aiuto aiuto merged commit 85bd2ad into bazelbuild:main Apr 1, 2022
@aiuto aiuto deleted the azip branch April 1, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jylinv0 jylinv0 jylinv0 left review comments

@nacl nacl nacl approved these changes

Assignees
No one assigned
Labels
P1 An issue that must be resolved. Must have an assignee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg_zip supports pkg_filegroup framework
3 participants
@aiuto @nacl @jylinv0