Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stardoc in MODULE.bazel so we can build with bazel 7.x in default mode #808

Closed
aiuto opened this issue Jan 10, 2024 · 1 comment · Fixed by #853
Closed

Update stardoc in MODULE.bazel so we can build with bazel 7.x in default mode #808

aiuto opened this issue Jan 10, 2024 · 1 comment · Fixed by #853
Labels
P1 An issue that must be resolved. Must have an assignee P2 An issue that should be worked on when time is available

Comments

@aiuto
Copy link
Collaborator

aiuto commented Jan 10, 2024

Right now you need to build with --noenable_bzlmod.
But, IIRC, the name of the repo is different under bzlmod, so you have to fix the build files.
Such is life.
@aiuto aiuto added the P2 An issue that should be worked on when time is available label Jan 10, 2024
@aiuto aiuto changed the title Update startdoc in MODULE.bazel so we can build with bazel 7.x in default mode Update stardoc in MODULE.bazel so we can build with bazel 7.x in default mode Mar 15, 2024
@aiuto aiuto added the P1 An issue that must be resolved. Must have an assignee label Apr 16, 2024
@aiuto
Copy link
Collaborator Author

aiuto commented Apr 16, 2024

Update: April 2024. Bazel at is pretty much breaking --noenable_bzlmod. You tend to get an error like

(02:55:28) ERROR: Error computing the main repository mapping: Label '@@platforms//host:extension.bzl' is invalid because 'host' is not a package; perhaps you meant to put the colon here: '@@platforms//:host/extension.bzl'?
(02:55:28) Computing main repo mapping:

@aiuto aiuto mentioned this issue Apr 16, 2024
Merged
meteorcloudy added a commit that referenced this issue Apr 16, 2024
@meteorcloudy
Force stardoc integration test to run with bazel 7.0.0 (#852)
bf30ed9 
Force the integration test (stardoc and packaging) to run with bazel
7.0.0.
Bazel at head seems to have broken --noenable_bzlmod in some cases. See
#808.

This also bumps platforms to the latest, but that was a red herring from
the error message in the underlying problem
aiuto added a commit to aiuto/rules_pkg that referenced this issue Apr 16, 2024
@aiuto
Update to new stardoc so we can work with bzlmod.
3eb9574 
Requires update to merge.py to account for stardoc changes.

Fixes bazelbuild#808
@aiuto aiuto mentioned this issue Apr 16, 2024
Merged
aiuto added a commit that referenced this issue Apr 17, 2024
@aiuto
Update to new stardoc so we can work with bzlmod. (#853)
36433a9 
* Update to new stardoc so we can work with bzlmod.
* Requires update to merge.py to account for stardoc changes.
* put integration test back on bazel at head.

Fixes #808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 An issue that must be resolved. Must have an assignee P2 An issue that should be worked on when time is available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to new stardoc so we can work with bzlmod. aiuto/rules_pkg
1 participant
@aiuto