pkg_tar package_dir parameter is encoded with the platform specific folder delimiters

[konste]

When pkg_tar is executed on Windows host and it has package_dir specified (like a/b/c) folder separators in package_dir are encoded in the resulting TAR in a platform specific way, i.e. on Windows they are encoded as backslashes. When that TAR is then expanded on Linux or Mac they don't understand backslashes and the content gets expanded to the wrong folder tree.

The result of pkg_tar should not depend on the platform it runs on. Folder separators should always be slashes, not backslashes, and then the resulting TAR would be perfectly usable on all platforms.

[aiuto]

Hmmm... I thought I had that right the first time. I'm trying to rebuild my windows environment (lost when working from home started) and don't have a dev machine right now. Can you send along a small tar file produced on windows so I can do some forensics?

[konste]

Repro is trivial, but still I added one to make sure we are on the same page: https://github.com/Bazel-snippets/pkg_tar_windows

I have zipped the TAR produced on Windows and attached here.
bazel-bin.zip

Regarding access to Windows environment AFAIR anybody can create a free account on Azure and get some amount of computational resources (which can be Windows VM) for free. If you don't have easier access to Windows I can look into it and probably create one for you.

[aiuto]

thanks

…

On Wed, Feb 24, 2021 at 11:30 AM Konstantin Erman ***@***.***> wrote: I am working on a repro. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHBBLALYSYG2YJY5PRDTAUSQVANCNFSM4YA4LEYQ> .