Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation: archive_name to be removed in all pkg_* rules #284

Closed
aiuto opened this issue Jan 28, 2021 · 0 comments · Fixed by #553
Closed

Deprecation: archive_name to be removed in all pkg_* rules #284

aiuto opened this issue Jan 28, 2021 · 0 comments · Fixed by #553
Labels
breaking change P2 An issue that should be worked on when time is available
Milestone
1.0

Comments

@aiuto
Copy link
Collaborator

aiuto commented Jan 28, 2021

package_file_name is a superset of the capabilities of archive_name.
Estimated date: 2021-08-01 or version 1.0, whichever comes first
@aiuto aiuto mentioned this issue Jan 28, 2021
Merged
@aiuto aiuto added the P2 An issue that should be worked on when time is available label Feb 24, 2021
@aiuto aiuto added this to the 1.0 milestone May 4, 2021
aiuto added a commit to aiuto/rules_pkg that referenced this issue Mar 1, 2022
@aiuto
Get rid of the long deprecated archive_name and extension from pkg_zip.
27360d1 
- Make 'out' work in a reasonable way. Fixes bazelbuild#414
- Partial fix for bazelbuild#284
aiuto added a commit to aiuto/rules_pkg that referenced this issue Mar 1, 2022
@aiuto
Get rid of the long deprecated archive_name and extension from pkg_zip.
71f8ab6 
- Make 'out' work in a reasonable way. Fixes bazelbuild#414
- Partial fix for bazelbuild#284
This was referenced Mar 1, 2022
Merged
Merged
@aiuto aiuto closed this as completed in #553 Mar 3, 2022
aiuto added a commit that referenced this issue Mar 7, 2022
@aiuto
Get rid of the long deprecated archive_name and extension from pkg_zi…
b710cac 
…p. (#552)

- Make 'out' work in a reasonable way. Fixes #414
- Partial fix for #284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change P2 An issue that should be worked on when time is available
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

drop archive_name from pkg_tar and pkg_deb aiuto/rules_pkg
1 participant
@aiuto