Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bazel CI] bazel: Lint starlark doc for kotlin packages fails with invalid repository name #1203

Closed
sgowroji opened this issue Aug 9, 2024 · 1 comment · Fixed by #1214
Closed

[Bazel CI] bazel: Lint starlark doc for kotlin packages fails with invalid repository name #1203

sgowroji opened this issue Aug 9, 2024 · 1 comment · Fixed by #1214
Assignees
@restingbull

Comments

@sgowroji
Copy link
Member

sgowroji commented Aug 9, 2024

CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4045#01913553-7d47-4e8f-8887-e0620b679dc0

Platform: Ubuntu

Logs:

ERROR: �[0m/var/lib/buildkite-agent/builds/bk-docker-jsv6/bazel-org-repo-root/rules_kotlin/kotlin/BUILD:39:12: Generating proto for Starlark doc for lint failed: (Exit 1): lint_stardoc failed: error executing Stardoc command (from target //kotlin:lint) 
Exception: com.google.devtools.build.lib.cmdline.LabelSyntaxException: invalid repository name '@rules_java+': repo names may contain only A-Z, a-z, 0-9, '-', '_', '.' and '~' and must not start with '~'
Exception: invalid repository name '@rules_java+': repo names may contain only A-Z, a-z, 0-9, '-', '_', '.' and '~' and must not start with '~'
ERROR: �[0m/var/lib/buildkite-agent/builds/bk-docker-jsv6/bazel-org-repo-root/rules_kotlin/kotlin/BUILD:39:12: Generating proto for Starlark doc for jvm failed: (Exit 1): jvm_stardoc failed: error executing Stardoc command (from target //kotlin:jvm) 
Exception: com.google.devtools.build.lib.cmdline.LabelSyntaxException: invalid repository name '@+rules_kotlin_extensions+com_github_jetbrains_kotlin': repo names may contain only A-Z, a-z, 0-9, '-', '_', '.' and '~' and must not start with '~'
Exception: invalid repository name '@+rules_kotlin_extensions+com_github_jetbrains_kotlin': repo names may contain only A-Z, a-z, 0-9, '-', '_', '.' and '~' and must not start with '~'

Culprit:

Steps:

git clone https://github.com/bazelbuild/rules_kotlin
git reset 9cfccc37e6e6e3d16595cb79f8baf4c20963d166  --hard
export USE_BAZEL_VERSION=c2d587a8020e1120ad15c2d3d3aa4d04b7301410
bazel build //kotlin:stardoc

CC Greenteam @meteorcloudy
@meteorcloudy
Copy link
Member

Probably caused by bazelbuild/bazel@60924fd

@restingbull restingbull self-assigned this Sep 6, 2024
restingbull added a commit that referenced this issue Sep 6, 2024
@restingbull
[stardoc] Update stardoc to 7.0.0
718a0b9 
Of special note:
> The Markdown renderer now uses Google EscapeVelocity instead of Apache Velocity for templating. The templating engines are almost compatible, with the exception of escapes in string literals: if in your template you had a string literal with a character escape, you would need to expand it.

[Release Notes for 0.6.0](https://github.com/bazelbuild/stardoc/releases/tag/0.6.0)

"almost", indeed. :/

fixes #1203
@restingbull restingbull mentioned this issue Sep 6, 2024
Merged
restingbull added a commit that referenced this issue Sep 6, 2024
@restingbull
[stardoc] Update stardoc to 7.0.0
9485823 
Of special note:
> The Markdown renderer now uses Google EscapeVelocity instead of Apache Velocity for templating. The templating engines are almost compatible, with the exception of escapes in string literals: if in your template you had a string literal with a character escape, you would need to expand it.

[Release Notes for 0.6.0](https://github.com/bazelbuild/stardoc/releases/tag/0.6.0)

"almost", indeed. :/

fixes #1203
restingbull added a commit that referenced this issue Sep 7, 2024
@restingbull
[stardoc] Update stardoc to 7.0.0
9762025 
Of special note:
> The Markdown renderer now uses Google EscapeVelocity instead of Apache Velocity for templating. The templating engines are almost compatible, with the exception of escapes in string literals: if in your template you had a string literal with a character escape, you would need to expand it.

[Release Notes for 0.6.0](https://github.com/bazelbuild/stardoc/releases/tag/0.6.0)

"almost", indeed. :/

fixes #1203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@restingbull restingbull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stardoc] Update stardoc to 0.7.0 bazelbuild/rules_kotlin
3 participants
@meteorcloudy @sgowroji @restingbull