Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Update rules_docker to v0.20.0 #669

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

mishas
Copy link
Contributor

@mishas mishas commented Oct 12, 2021

New version of rules_docker was release, and it has a change that breaks rules_k8s.

@k8s-ci-robot
Copy link

Hi @mishas. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mishas
Copy link
Contributor Author

mishas commented Oct 12, 2021

/assign @chizhg

@chizhg
Copy link

chizhg commented Oct 12, 2021

/ok-to-test
/lgtm
/approve

@mishas
Copy link
Contributor Author

mishas commented Oct 12, 2021

Hello @chizhg and @fejta ,

I'm not really sure about how the "praw" process works, but from the link in "The pull request process is described here" mentioned above it says that the PR will get automatically merged if all tests pass and the PR has the "LGTM" and "approved" labels.

I'm not sure if it's a bug in the automated system, or is there anything else that needs to be done here?

Thank you.

@mishas
Copy link
Contributor Author

mishas commented Oct 14, 2021

Hello @chizhg and @fejta ,

Sorry for bugging you again - but this is still approved but not merged :(

Thank you.

@chizhg
Copy link

chizhg commented Oct 18, 2021

/assign @fejta
Shall we configure Tide for this repo?

@fejta
Copy link
Contributor

fejta commented Oct 19, 2021

We should first move it to oss-prow.knative.dev

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg, fejta, mishas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants