Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade x/tools to 0.15.0 #3751

Merged
merged 2 commits into from
Nov 13, 2023
+22,350 −22,032
Merged

upgrade x/tools to 0.15.0 #3751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7be0f68
upgrade x/tools to v0.15.0
tyler-french Nov 12, 2023
022d60e
Merge branch 'master' into tools-15
tyler-french Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions go/private/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ def go_rules_dependencies(force = False):
wrapper(
http_archive,
name = "org_golang_x_tools",
# v0.14.0, latest as of 2023-10-29
# v0.15.0, latest as of 2023-11-12
urls = [
"https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.14.0.zip",
"https://github.com/golang/tools/archive/refs/tags/v0.14.0.zip",
"https://mirror.bazel.build/github.com/golang/tools/archive/refs/tags/v0.15.0.zip",
"https://github.com/golang/tools/archive/refs/tags/v0.15.0.zip",
],
sha256 = "9c71911c61a791d8b13368ffbc409a0b38859cac80a4b5039487d2a27399e8b9",
strip_prefix = "tools-0.14.0",
sha256 = "e76a03b11719138502c7fef44d5e1dc4469f8c2fcb2ee4a1d96fb09aaea13362",
strip_prefix = "tools-0.15.0",
patches = [
# deletegopls removes the gopls subdirectory. It contains a nested
# module with additional dependencies. It's not needed by rules_go.
Expand Down
4 changes: 2 additions & 2 deletions go/tools/builders/nogo_main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ func checkPackage(analyzers []*analysis.Analyzer, packagePath string, packageFil

// Process diagnostics and encode facts for importers of this package.
diagnostics := checkAnalysisResults(roots, pkg)
facts := pkg.facts.Encode(true/* skipMethodSorting */)
facts := pkg.facts.Encode()
return diagnostics, facts, nil
}

Expand Down Expand Up @@ -396,7 +396,7 @@ func load(packagePath string, imp *importer, filenames []string) (*goPackage, er
}
pkg.types, pkg.typesInfo = types, info

pkg.facts, err = facts.NewDecoder(pkg.types).Decode(true/* skipMethodSorting */, imp.readFacts)
pkg.facts, err = facts.NewDecoder(pkg.types).Decode(imp.readFacts)
if err != nil {
return nil, fmt.Errorf("internal error decoding facts: %v", err)
}
Expand Down
1 change: 0 additions & 1 deletion tests/integration/popular_repos/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ test_suite(
"@org_golang_x_tools//internal/event/export/ocagent:ocagent_test",
"@org_golang_x_tools//internal/event/export/ocagent/wire:wire_test",
"@org_golang_x_tools//internal/event/label:label_test",
"@org_golang_x_tools//internal/fastwalk:fastwalk_test",
"@org_golang_x_tools//internal/fuzzy:fuzzy_test",
"@org_golang_x_tools//internal/gopathwalk:gopathwalk_test",
"@org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test",
Expand Down
3 changes: 0 additions & 3 deletions tests/integration/popular_repos/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ This runs tests from the repository `golang.org/x/tools <https://golang.org/x/to
* @org_golang_x_tools//internal/event/export/ocagent:ocagent_test
* @org_golang_x_tools//internal/event/export/ocagent/wire:wire_test
* @org_golang_x_tools//internal/event/label:label_test
* @org_golang_x_tools//internal/fastwalk:fastwalk_test
* @org_golang_x_tools//internal/fuzzy:fuzzy_test
* @org_golang_x_tools//internal/gopathwalk:gopathwalk_test
* @org_golang_x_tools//internal/jsonrpc2:jsonrpc2_test
Expand Down Expand Up @@ -232,5 +231,3 @@ This runs tests from the repository `golang.org/x/mod <https://golang.org/x/mod>
* @org_golang_x_mod//sumdb/dirhash:dirhash_test
* @org_golang_x_mod//sumdb/note:note_test
* @org_golang_x_mod//sumdb/storage:storage_test


Loading