Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix //tests/legacy/examples/cgo:cgo_lib_test on M1 Macs #3237

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jul 14, 2022

The CPU config setting didn't match for M1 Macs, which are darwin_arm64.
Instead, use a more modern @platforms condition for the special casing.

We should ultimately fix the underlying issue with linking on macOS
instead.

The CPU config setting didn't match for M1 Macs, which are darwin_arm64.
Instead, use a more modern @platforms condition for the special casing.

We should ultimately fix the underlying issue with linking on macOS
instead.
@sluongng
Copy link
Contributor

master ~/work/misc/rules_go> git diff
diff --git a/tests/legacy/examples/cgo/cc_dependency/BUILD.bazel b/tests/legacy/examples/cgo/cc_dependency/BUILD.bazel
index bace2050..f0eee7dd 100644
--- a/tests/legacy/examples/cgo/cc_dependency/BUILD.bazel
+++ b/tests/legacy/examples/cgo/cc_dependency/BUILD.bazel
@@ -1,8 +1,3 @@
-config_setting(
-    name = "darwin",
-    values = {"cpu": "darwin"},
-)
-
 cc_library(
     name = "version",
     srcs = ["cxx_version.cc"],
@@ -12,7 +7,7 @@ cc_library(
     # TODO(yugui) Support darwin too and remove this workaround.
     # See also comments in cxx_version.cc.
     deps = select({
-        ":darwin": [],
+        "@platforms//os:macos": [],
         "//conditions:default": [":c_version_import"],
     }),
 )
master ~/work/misc/rules_go> bazel test tests/legacy/examples/cgo:cgo_lib_test --verbose_failures --test_output=errors --sandbox_debug
INFO: Invocation ID: 5e6bac6d-a748-4896-b048-b4394427cd16
DEBUG: /private/var/tmp/_bazel_sngoc/2a28a4eea77aca2bd34246f26b53d6f4/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:68:14:
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.
DEBUG: /private/var/tmp/_bazel_sngoc/2a28a4eea77aca2bd34246f26b53d6f4/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:14: buildkite_config not using checked in configs; Bazel version 5.2.0 was picked/selected but no checked in config was found in map {"0.20.0": ["8.0.0"], "0.21.0": ["8.0.0"], "0.22.0": ["8.0.0", "9.0.0"], "0.23.0": ["8.0.0", "9.0.0"], "0.23.1": ["8.0.0", "9.0.0"], "0.23.2": ["9.0.0"], "0.24.0": ["9.0.0"], "0.24.1": ["9.0.0"], "0.25.0": ["9.0.0"], "0.25.1": ["9.0.0"], "0.25.2": ["9.0.0"], "0.26.0": ["9.0.0"], "0.26.1": ["9.0.0"], "0.27.0": ["9.0.0"], "0.27.1": ["9.0.0"], "0.28.0": ["9.0.0"], "0.28.1": ["9.0.0"], "0.29.0": ["9.0.0"], "0.29.1": ["9.0.0", "10.0.0"], "1.0.0": ["9.0.0", "10.0.0"], "1.0.1": ["10.0.0"], "1.1.0": ["10.0.0"], "1.2.0": ["10.0.0"], "1.2.1": ["10.0.0"], "2.0.0": ["10.0.0"], "2.1.0": ["10.0.0"], "2.1.1": ["10.0.0", "11.0.0"], "2.2.0": ["11.0.0"], "3.0.0": ["11.0.0"], "3.1.0": ["11.0.0"], "3.2.0": ["11.0.0"], "3.3.0": ["11.0.0"], "3.3.1": ["11.0.0"], "3.4.1": ["11.0.0"], "3.5.0": ["11.0.0"], "3.5.1": ["11.0.0"], "3.6.0": ["11.0.0"], "3.7.0": ["11.0.0"], "3.7.1": ["11.0.0"], "3.7.2": ["11.0.0"], "4.0.0": ["11.0.0"]}
INFO: Analyzed target //tests/legacy/examples/cgo:cgo_lib_test (0 packages loaded, 0 targets configured).
INFO: Found 1 test target...
Target //tests/legacy/examples/cgo:cgo_lib_test up-to-date:
  bazel-bin/tests/legacy/examples/cgo/cgo_lib_test_/cgo_lib_test
INFO: Elapsed time: 0.697s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//tests/legacy/examples/cgo:cgo_lib_test                        (cached) PASSED in 2.9s

INFO: Build completed successfully, 1 total action

It worked 🙌
Nicely done!

@fmeum fmeum merged commit 8fe3a08 into bazelbuild:master Jul 14, 2022
@fmeum fmeum deleted the fix-cc-dependency-test-on-M1 branch July 14, 2022 06:42
gcf-merge-on-green bot referenced this pull request in googleapis/gapic-generator-go Jul 19, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | minor | `v0.33.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go</summary>

### [`v0.34.0`](https://github.com/bazelbuild/rules_go/releases/tag/v0.34.0)

[Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.33.0...v0.34.0)

#### What's Changed

-   releaser: fix scrubbing timestamp from patch files by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3180](https://github.com/bazelbuild/rules_go/pull/3180)
-   Replace Starlark JSON parser with json.decode by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3184](https://github.com/bazelbuild/rules_go/pull/3184)
-   gopackagesdriver: separates "s" files in pkg info by [@&#8203;iamricard](https://github.com/iamricard) in [https://github.com/bazelbuild/rules_go/pull/3165](https://github.com/bazelbuild/rules_go/pull/3165)
-   Refactor away references to @&#8203;io_bazel_rules_go by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3185](https://github.com/bazelbuild/rules_go/pull/3185)
-   Do not print to stderr if cgo linking succeeds after retry by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3187](https://github.com/bazelbuild/rules_go/pull/3187)
-   Use param files with go-protoc by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3190](https://github.com/bazelbuild/rules_go/pull/3190)
-   Don't include non-executable go_binary in dependent's runfiles by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3151](https://github.com/bazelbuild/rules_go/pull/3151)
-   Link in native libraries of transitive dependencies in archive mode by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3186](https://github.com/bazelbuild/rules_go/pull/3186)
-   runfiles: remove deprecated api by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3198](https://github.com/bazelbuild/rules_go/pull/3198)
-   Fix failing open hermeticity test by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3206](https://github.com/bazelbuild/rules_go/pull/3206)
-   Fix go_googleapis Gazelle patch by [@&#8203;nickgooding](https://github.com/nickgooding) in [https://github.com/bazelbuild/rules_go/pull/3193](https://github.com/bazelbuild/rules_go/pull/3193)
-   Exclude unsupported C/C++ features by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3189](https://github.com/bazelbuild/rules_go/pull/3189)
-   Allow gomock to take Bazel common attributes by [@&#8203;linzhp](https://github.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3207](https://github.com/bazelbuild/rules_go/pull/3207)
-   Transition on edges not self by [@&#8203;illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3116](https://github.com/bazelbuild/rules_go/pull/3116)
-   Include go_transition_test in bazel aspect by [@&#8203;ian-h-chamberlain](https://github.com/ian-h-chamberlain) in [https://github.com/bazelbuild/rules_go/pull/3160](https://github.com/bazelbuild/rules_go/pull/3160)
-   Add an example for go_download_sdk.sdks by [@&#8203;fishy](https://github.com/fishy) in [https://github.com/bazelbuild/rules_go/pull/3139](https://github.com/bazelbuild/rules_go/pull/3139)
-   tests: nogo over generated code by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3214](https://github.com/bazelbuild/rules_go/pull/3214)
-   test nogo/coverage: test generated code by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3213](https://github.com/bazelbuild/rules_go/pull/3213)
-   Remove references to go_transition_test by [@&#8203;linzhp](https://github.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3215](https://github.com/bazelbuild/rules_go/pull/3215)
-   Basic bzlmod setup by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3047](https://github.com/bazelbuild/rules_go/pull/3047)
-   Run BCR tests against Bazel 6.0.0-pre.20220608.2 by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3223](https://github.com/bazelbuild/rules_go/pull/3223)
-   Use repo-relative labels in MODULE.bazel by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3226](https://github.com/bazelbuild/rules_go/pull/3226)
-   upkeep: upgrade to go 1.18.3 and gazelle v0.26.0 by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3220](https://github.com/bazelbuild/rules_go/pull/3220)
-   nogo: ignore generated source files by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3216](https://github.com/bazelbuild/rules_go/pull/3216)
-   asm: Pass package path with -p by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3231](https://github.com/bazelbuild/rules_go/pull/3231)
-   bzlmod: Add support for gomock by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3232](https://github.com/bazelbuild/rules_go/pull/3232)
-   test cgo: ensure helper script works by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3236](https://github.com/bazelbuild/rules_go/pull/3236)
-   Fix //tests/legacy/examples/cgo:cgo_lib_test on M1 Macs by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3237](https://github.com/bazelbuild/rules_go/pull/3237)
-   gopackagesdriver: Descend into go_proto_compiler's deps by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3240](https://github.com/bazelbuild/rules_go/pull/3240)
-   new_library: remove unused resolver by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3219](https://github.com/bazelbuild/rules_go/pull/3219)
-   nogo: instantiate type info for generic types when running under Go >=1.18 by [@&#8203;farhaven](https://github.com/farhaven) in [https://github.com/bazelbuild/rules_go/pull/3212](https://github.com/bazelbuild/rules_go/pull/3212)

#### New Contributors

-   [@&#8203;iamricard](https://github.com/iamricard) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3165](https://github.com/bazelbuild/rules_go/pull/3165)
-   [@&#8203;ian-h-chamberlain](https://github.com/ian-h-chamberlain) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3160](https://github.com/bazelbuild/rules_go/pull/3160)
-   [@&#8203;fishy](https://github.com/fishy) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3139](https://github.com/bazelbuild/rules_go/pull/3139)
-   [@&#8203;farhaven](https://github.com/farhaven) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3212](https://github.com/bazelbuild/rules_go/pull/3212)

**Full Changelog**: bazelbuild/rules_go@v0.33.0...v0.34.0

#### `WORKSPACE` code

    load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

    http_archive(
        name = "io_bazel_rules_go",
        sha256 = "16e9fca53ed6bd4ff4ad76facc9b7b651a89db1689a2877d6fd7b82aa824e366",
        urls = [
            "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip",
            "https://github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip",
        ],
    )

    load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.18.4")

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-go).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
gcf-merge-on-green bot referenced this pull request in googleapis/gapic-config-validator Jul 19, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | minor | `v0.33.0` -> `v0.34.0` |

---

### Release Notes

<details>
<summary>bazelbuild/rules_go</summary>

### [`v0.34.0`](https://github.com/bazelbuild/rules_go/releases/tag/v0.34.0)

[Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.33.0...v0.34.0)

#### What's Changed

-   releaser: fix scrubbing timestamp from patch files by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3180](https://github.com/bazelbuild/rules_go/pull/3180)
-   Replace Starlark JSON parser with json.decode by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3184](https://github.com/bazelbuild/rules_go/pull/3184)
-   gopackagesdriver: separates "s" files in pkg info by [@&#8203;iamricard](https://github.com/iamricard) in [https://github.com/bazelbuild/rules_go/pull/3165](https://github.com/bazelbuild/rules_go/pull/3165)
-   Refactor away references to @&#8203;io_bazel_rules_go by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3185](https://github.com/bazelbuild/rules_go/pull/3185)
-   Do not print to stderr if cgo linking succeeds after retry by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3187](https://github.com/bazelbuild/rules_go/pull/3187)
-   Use param files with go-protoc by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3190](https://github.com/bazelbuild/rules_go/pull/3190)
-   Don't include non-executable go_binary in dependent's runfiles by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3151](https://github.com/bazelbuild/rules_go/pull/3151)
-   Link in native libraries of transitive dependencies in archive mode by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3186](https://github.com/bazelbuild/rules_go/pull/3186)
-   runfiles: remove deprecated api by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3198](https://github.com/bazelbuild/rules_go/pull/3198)
-   Fix failing open hermeticity test by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3206](https://github.com/bazelbuild/rules_go/pull/3206)
-   Fix go_googleapis Gazelle patch by [@&#8203;nickgooding](https://github.com/nickgooding) in [https://github.com/bazelbuild/rules_go/pull/3193](https://github.com/bazelbuild/rules_go/pull/3193)
-   Exclude unsupported C/C++ features by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3189](https://github.com/bazelbuild/rules_go/pull/3189)
-   Allow gomock to take Bazel common attributes by [@&#8203;linzhp](https://github.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3207](https://github.com/bazelbuild/rules_go/pull/3207)
-   Transition on edges not self by [@&#8203;illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3116](https://github.com/bazelbuild/rules_go/pull/3116)
-   Include go_transition_test in bazel aspect by [@&#8203;ian-h-chamberlain](https://github.com/ian-h-chamberlain) in [https://github.com/bazelbuild/rules_go/pull/3160](https://github.com/bazelbuild/rules_go/pull/3160)
-   Add an example for go_download_sdk.sdks by [@&#8203;fishy](https://github.com/fishy) in [https://github.com/bazelbuild/rules_go/pull/3139](https://github.com/bazelbuild/rules_go/pull/3139)
-   tests: nogo over generated code by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3214](https://github.com/bazelbuild/rules_go/pull/3214)
-   test nogo/coverage: test generated code by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3213](https://github.com/bazelbuild/rules_go/pull/3213)
-   Remove references to go_transition_test by [@&#8203;linzhp](https://github.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3215](https://github.com/bazelbuild/rules_go/pull/3215)
-   Basic bzlmod setup by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3047](https://github.com/bazelbuild/rules_go/pull/3047)
-   Run BCR tests against Bazel 6.0.0-pre.20220608.2 by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3223](https://github.com/bazelbuild/rules_go/pull/3223)
-   Use repo-relative labels in MODULE.bazel by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3226](https://github.com/bazelbuild/rules_go/pull/3226)
-   upkeep: upgrade to go 1.18.3 and gazelle v0.26.0 by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3220](https://github.com/bazelbuild/rules_go/pull/3220)
-   nogo: ignore generated source files by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3216](https://github.com/bazelbuild/rules_go/pull/3216)
-   asm: Pass package path with -p by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3231](https://github.com/bazelbuild/rules_go/pull/3231)
-   bzlmod: Add support for gomock by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3232](https://github.com/bazelbuild/rules_go/pull/3232)
-   test cgo: ensure helper script works by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3236](https://github.com/bazelbuild/rules_go/pull/3236)
-   Fix //tests/legacy/examples/cgo:cgo_lib_test on M1 Macs by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3237](https://github.com/bazelbuild/rules_go/pull/3237)
-   gopackagesdriver: Descend into go_proto_compiler's deps by [@&#8203;fmeum](https://github.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3240](https://github.com/bazelbuild/rules_go/pull/3240)
-   new_library: remove unused resolver by [@&#8203;sluongng](https://github.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3219](https://github.com/bazelbuild/rules_go/pull/3219)
-   nogo: instantiate type info for generic types when running under Go >=1.18 by [@&#8203;farhaven](https://github.com/farhaven) in [https://github.com/bazelbuild/rules_go/pull/3212](https://github.com/bazelbuild/rules_go/pull/3212)

#### New Contributors

-   [@&#8203;iamricard](https://github.com/iamricard) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3165](https://github.com/bazelbuild/rules_go/pull/3165)
-   [@&#8203;ian-h-chamberlain](https://github.com/ian-h-chamberlain) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3160](https://github.com/bazelbuild/rules_go/pull/3160)
-   [@&#8203;fishy](https://github.com/fishy) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3139](https://github.com/bazelbuild/rules_go/pull/3139)
-   [@&#8203;farhaven](https://github.com/farhaven) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3212](https://github.com/bazelbuild/rules_go/pull/3212)

**Full Changelog**: bazelbuild/rules_go@v0.33.0...v0.34.0

#### `WORKSPACE` code

    load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

    http_archive(
        name = "io_bazel_rules_go",
        sha256 = "16e9fca53ed6bd4ff4ad76facc9b7b651a89db1689a2877d6fd7b82aa824e366",
        urls = [
            "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip",
            "https://github.com/bazelbuild/rules_go/releases/download/v0.34.0/rules_go-v0.34.0.zip",
        ],
    )

    load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

    go_rules_dependencies()

    go_register_toolchains(version = "1.18.4")

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-config-validator).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants