Setting coverage mode to atomic when race detection is enabled #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayconrod
reviewed
May 15, 2020
There was a problem hiding this comment.
Thanks for fixing this!
Please also update //tests/core/race:race_test to verify this. I think you can add a go_library target with some code similar to that blog post, then add a go_test target with race = "on" that exercises that code. Then test with coverage.
linzhp
commented
May 16, 2020
jayconrod
approved these changes
May 18, 2020
jayconrod
pushed a commit
that referenced
this pull request
May 27, 2020
-covermode=set cannot be run with race detection. This PR set -covermode=atomic when race detection is enabled. More information at https://hermanschaaf.com/running-the-go-race-detector-with-cover/ Fixes #2498
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this pull request
May 28, 2020
Test case was added in bazelbuild#2502. bazelbuild#2509 enabled tests and caused it to start failing. Skipped for now. Updates bazelbuild#2518
jayconrod
pushed a commit
that referenced
this pull request
May 28, 2020
jayconrod
pushed a commit
that referenced
this pull request
May 28, 2020
jayconrod
pushed a commit
that referenced
this pull request
Jul 8, 2020
-covermode=set cannot be run with race detection. This PR set -covermode=atomic when race detection is enabled. More information at https://hermanschaaf.com/running-the-go-race-detector-with-cover/ Fixes #2498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
-covermode=setcannot be run with race detection. This PR set-covermode=atomicwhen race detection is enabled. More information at https://hermanschaaf.com/running-the-go-race-detector-with-cover/Which issues(s) does this PR fix?
Fixes #2498
Other notes for review