Gazelle: packages.Walk now calls back in all subdirectories #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walk now calls its callback in all directories it traverses, whether or not they have buildable code or are outside of the subtrees Gazelle was asked to update. This is needed for import path indexing, since we'll need to scan rules in all directories. Related bazelbuild#859
ianthehat
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walk now calls its callback in all directories it traverses, whether
or not they have buildable code or are outside of the subtrees Gazelle
was asked to update.
This is needed for import path indexing, since we'll need to scan
rules in all directories.
Related #859