Remove emit_swiftinterface from the Apple rule transitions.
#2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AttilaTheFun
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
AttilaTheFun
force-pushed
the
master
branch
2 times, most recently
from
b1e0430 to
8384c24
Compare
luispadron
approved these changes
Jan 10, 2025
brentleyjones
approved these changes
Jan 21, 2025
|
Hmm, this is a breaking change, right? |
Instead of relying on the transition to set the flag throughout the dependency graph, users should set `library_evolution = True` on the specific libraries that they want to support library evolution. PiperOrigin-RevId: 629760009 (cherry picked from commit 24a862d)
|
@brentleyjones You already cherry-picked the removal of the build config from rules_swift, so the head of rules_apple is now incompatible with the head of rules_swift without this change. We either need to revert the change in rules_swift, or apply this change to rules_apple from upstream. |
|
Sure, we need this, but I'm wondering if it means a 4.0 version bump. |
|
How do you view what counts as a breaking change? If we cut a new version of rules_apple for this, I'd argue we'd need a new version of rules_swift, too. It was actually that breakage that necessitated this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the transition to set the flag throughout the dependency graph, users should set
library_evolution = Trueon the specific libraries that they want to support library evolution.PiperOrigin-RevId: 629760009
(cherry picked from commit 24a862d)