Upgrade rules_go, Gazelle, Go SDK, googleapis, com_google_protobuf #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
approved these changes
Sep 16, 2023
|
@bergsieker do you think we could merge this? I'm interested in having a go at bzlmod support for remote-apis, but it's hindered by the dependencies being out of date. I'd like to avoid that being a PR which also bumps a lot of dependencies. |
werkt
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
This seems to simplify and pave the way for bzlmod support. @bergsieker recommend we land this.
bergsieker
reviewed
Dec 6, 2023
There was a problem hiding this comment.
I'm concerned that this is actually moving us further from our goal of removing the generated go bindings and making this a proto-only reference repository. However, I acknowledge that we haven't been actively pursuing that goal, so it makes sense not to block progress in order to maintain the status quo.
bergsieker
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_go 0.41.0 no longer comes with
@go_googleapisrepo. This update the references of Google APIs Go code to@org_golang_google_genproto. In order to work with the new version of rules_go, this PR also update:Fixed #264
This should be merged before #268 and #265 because later versions of googleapis requires latest rules_go