-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed partial ExecutedActionMetadata in ExecuteOperationMetadata #238
Conversation
9b89150
to
766a7c1
Compare
I like the idea of this - it seems useful to find out where an action is executing (presumably this can be found out on the server side but this makes it easier to see it on the client). I'm a little dubious about the Any though. It seems tricky for a client to know how to interpret it - there is prior art with the |
Any thoughts on default fields? I'd personally like (at least) the worker name and the various milestones in the |
Yup, I agree on those. I think |
I think that's a good compromise. Updated the comment. |
This LGTM as well. @sstriker I see you assigned yourself: anything more needed here? |
No, we're good to go. |
The
ExecutedActionMetadata
contains a lot of interesting information about the work that was done, such as the worker the job was run on, timestamps for various execution milestones, and so on. This information is currently only available after the work is complete, in theActionResult
. However, I think some of these things would be useful to look at while the execution is running as well, especially in the context of UI tools that can show the status of ongoing work (e.g. bgd-browser).Unfortunately, there isn't currently a place to put this in the longrunning
Operation
that clients get back when waiting for a job. The only metadata field is used by theExecuteOperationMetadata
message, which has a very limited set of fields. So this PR just adds anExecutedActionMetadata
field inExecuteOperationMetadata
.