update rules_go #195
Merged
update rules_go #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atetubou
requested review from
agoulti,
bergsieker,
buchgr and
ola-rozenfeld
as code owners
google-cla
bot
added
the
cla: yes
This is to use protobuf v2 library for Go.
|
cc @EricBurnett |
|
Could we also use this occasion to migrate to Gazelle’s new way of naming targets? We still declare some go_default_library targets. |
|
Which way are you supposed to migrate? I currently feel that there is no established way to handle generated *.pb.go for bazel. Also I'd like to focus only to update bazel rules in this PR. |
|
ping? |
|
I'm going to approve this with the hope that it doesn't break anyone, but the recognition that there's a high probability that we'll need to roll back. Having pre-generated go bindings in this repository is really a bad idea because it puts us in the impossible position of trying to make everyone happy. I'd strongly suggest moving to generating your own bindings in your own repository. |
|
Thanks, but we use this via https://github.com/bazelbuild/remote-apis-sdks. So it is better to have *.pb.go eventually there? |
bergsieker
pushed a commit
that referenced
this pull request
May 20, 2021
Currently this repo exposes one function to install its dependencies, through switched_rules_by_language which invokes remote_apis_go_deps for golang. The issues arises from remote_apis_go_deps declaring **and** registering a go toolchain. We need to register a go toolchain so we can, eg, run gazelle to clean this repo's BUILD rules. However, this is problematic for other repos that may import this one but need a different golang version. On v0.20.1, rules_go used the argument name `go_version` to specify a version. Recent `rules_go` releases use `version` for specifying a golang version, so projects importing this one before #195 would luckily not run into issues. On v0.27.0, the same argument name is used and `rules_go` does not like that you may try to attempt registering two golang versions as the current toolchain. This code exploits that `rules_go` does not currently check that you're trying to install multiple `go_sdk`s with the same name (in this case, the default name which is coincidentally `go_sdk`). Luckily, the first one declared takes precendence, allowing projects importing this one to use a different go version. (I couldn't actually find a bazel doc stating that registering the same named toolchain twice would ignore the second registering, but I managed to test this empirically by calling `go_register_toolchains` and then loading this repo.) Naturally, I think the best option long term would be to tweak these go dependencies into two separate functions where one installs the go toolchain in this repo's workspaces for eg running gazelle, and another that exposes the necessary package dependencies for projects that import this one - but for the interest of my own time and bazel being "complicated", I went with the easier solution for now, which effectivelly reverts functionality to pre #195. Besides, breaking the go dependencies install would have to change the `switched_rules_by_language` signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to use protobuf v2 library for Go.