List EngFlow as another implementation #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clearly mark which ones are open source, and which are commercial ones. If you can't accept this for policy reasons, I'd strongly recommend clarifying the policy around which implementations are listed here and also *being transparent* in the documentation that this is the case.
ulfjack
requested review from
agoulti,
bergsieker,
buchgr and
ola-rozenfeld
as code owners
googlebot
added
the
cla: yes
|
LGTM! |
bergsieker
approved these changes
Apr 4, 2020
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
As usual, Go proto files need to be checked in to work with go build. Modeling our pre-commit hooks after the remote-apis repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clearly mark which ones are open source, and which are commercial ones.
If you can't accept this for policy reasons, I'd strongly recommend clarifying the policy around which implementations are listed here and also being transparent in the documentation that this is the case.