Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Locating runfiles with Bzlmod" #269

Merged
merged 10 commits into from
Aug 17, 2022
Merged

Add "Locating runfiles with Bzlmod" #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
27707aa
Add "Locating runfiles with Bzlmod"
fmeum Jul 18, 2022
d33bd4a
Address review comments
fmeum Jul 22, 2022
87374d1
Address comment on workspace name
fmeum Jul 22, 2022
24144cd
Clarify that the main repo's canonical name does not start with @
fmeum Jul 22, 2022
5d0d963
Determine the repo context in Rlocation, not Create
fmeum Jul 22, 2022
1924d3b
Address @oquenchil's comments
fmeum Aug 10, 2022
d72d749
Clarify why RunfilesLibraryUsersProvider is needed
fmeum Aug 10, 2022
0952711
Add a further special case and fix the example
fmeum Aug 10, 2022
e645fec
Propose to reuse RunfilesProvider
fmeum Aug 17, 2022
ae3f1fc
Mark as approved
fmeum Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ list.

| Last updated | Title | Author(s) alias | Category |
| ------------ | ------------------------------------------------------------------------------------------------------------------ | ---------------------------------------------------------------------------------- | -------- |
| 2022-08-17 | [Locating runfiles with Bzlmod](designs/2022-07-21-locating-runfiles-with-bzlmod.md) | [@fmeum](https://github.com/fmeum) | External Repositories, Bazel |
| 2022-06-30 | [Credential Helpers for Bazel](designs/2022-06-07-bazel-credential-helpers.md) | [@Yannic](https://github.com/Yannic) | External Repositories |
| 2022-05-25 | [Canonical label literals](https://docs.google.com/document/d/1N81qfCa8oskCk5LqTW-LNthy6EBrDot7bdUsjz6JFC4/edit#) | [@Wyverald](https://github/Wyverald) | External Repositories |
| 2022-05-11 | [Deprecating managed_directories](https://docs.google.com/document/d/1u9V5RUc7i6Urh8gGfnSurxpWA7JMRtwCi1Pr5BHeE44/edit?usp=sharing) | [@lberki](https://github.com/lberki) | External Repositories |
Expand Down
Loading