Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: java_tools v13.4.0 #87

Closed
keertk opened this issue Jan 8, 2024 · 17 comments
Closed

Release: java_tools v13.4.0 #87

keertk opened this issue Jan 8, 2024 · 17 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) release

Comments

@keertk
Copy link
Member

keertk commented Jan 8, 2024

Link to relevant issue and/or commit:
bazelbuild/bazel#20360
bazelbuild/bazel#20845 (comment)
bazelbuild/bazel#21119 (comment)

Other details: N/A

cc @bazelbuild/triage

@iancha1992
Copy link
Member

@fmeum
Copy link

fmeum commented Jan 8, 2024

@iancha1992 Could you post the error here? I can't access the link, but maybe I can help.

@iancha1992
Copy link
Member

Here you go!:
java-tools-binaries-java_build_243_ubuntu.log

@fmeum
Copy link

fmeum commented Jan 8, 2024

Thanks, pretty sure this is bazelbuild/bazel#20753

@keertk
Copy link
Member Author

keertk commented Jan 12, 2024

Do we wait for bazelbuild/bazel#20753 or is there a workaround so we can proceed with the java_tools release in the meantime?

@fmeum
Copy link

fmeum commented Jan 12, 2024

@keertk You could try setting USE_BAZEL_VERSION to the latest release-7.0.1 commit for the CI job.

@keertk
Copy link
Member Author

keertk commented Jan 16, 2024

So this got rid of the failures from earlier but we're now seeing issues with bazel_java_test_local_java_tools_jdk11 -

Let me know if I'm missing something or if there's another step needed?

@fmeum
Copy link

fmeum commented Jan 16, 2024

@keertk the link isn't public, could you share the log?

@keertk
Copy link
Member Author

keertk commented Jan 16, 2024

@fmeum I've attached the log in the comment above as well.
Lmk if you'd like more details!

@fmeum
Copy link

fmeum commented Jan 17, 2024

I would have expected this line to have set zip_path to the copied zip, but apparently that doesn't happen. I don't know why.

Can you run the script with set -x to give us better logs?

@keertk
Copy link
Member Author

keertk commented Jan 21, 2024

@fmeum I'll take a look tomorrow and let you know. Apologies for the delay.

@keertk
Copy link
Member Author

keertk commented Jan 31, 2024

Hi @fmeum coming back to this one - do we just wait for bazelbuild/bazel#20753 before moving forward?

@fmeum
Copy link

fmeum commented Feb 1, 2024

Probably yes, although I'm not certain that this is the root cause. But we should wait for @hvadehra to come back, maybe he has an idea.

copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Feb 5, 2024
Tempoarily workaround #20753 to unblock bazelbuild/java_tools#87

Setting `--sandbox_tmpfs_path=/tmp` for linux matches [the current behavior of bazelci.py](https://github.com/bazelbuild/continuous-integration/blob/7a8d90d15520b81e0f330a85772c5416a04d0061/buildkite/bazelci.py#L1976)

PiperOrigin-RevId: 604341263
Change-Id: I37fe324afe4328d861b06fc64a03e82cc55de38f
@hvadehra
Copy link
Member

hvadehra commented Feb 5, 2024

Releasing from master/head should be unblocked by bazelbuild/bazel@3f63602

@iancha1992
Copy link
Member

iancha1992 commented Feb 6, 2024

Step 2:
https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/253

Step 3:
COMMIT_HASH: 3f636025a5a6df929ad9d744fffb08c1d1ec408c

Step 4:

{
    "version": "v13.4",
    "release": "false",
    "artifacts": {
      "java_tools_linux": {
        "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.4/java_tools_linux-v13.4-rc1.zip",
        "sha": "ba10f09a138cf185d04cbc807d67a3da42ab13d618c5d1ce20d776e199c33a39"
        },
        "java_tools_windows": {
          "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.4/java_tools_windows-v13.4-rc1.zip",
          "sha": "fe2f88169696d6c6fc6e90ba61bb46be7d0ae3693cbafdf336041bf56679e8d1"
        },
        "java_tools_darwin_x86_64": {
          "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.4/java_tools_darwin_x86_64-v13.4-rc1.zip",
          "sha": "4523aec4d09c587091a2dae6f5c9bc6922c220f3b6030e5aba9c8f015913cc65"
        },
        "java_tools_darwin_arm64": {
          "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.4/java_tools_darwin_arm64-v13.4-rc1.zip",
          "sha": "076a7e198ad077f8c7d997986ef5102427fae6bbfce7a7852d2e080ed8767528"
        },
        "java_tools": {
          "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.4/java_tools-v13.4-rc1.zip",
          "sha": "e025fd260ac39b47c111f5212d64ec0d00d85dec16e49368aae82fc626a940cf"
        }
  }
}

Step 5:
Commit: bazelbuild/rules_java@5e520b1
5e520b1e3a3243628ad112968f9806df5505bb7f

Step 6 / 7:
PR: bazelbuild/bazel#21222
Presubmit: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/19807

Step 8:
Downstream build: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3641

Step 9:

{
  "version": "v13.4",
  "release": "true",
  "artifacts": {
    "java_tools_linux": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.4/java_tools_linux-v13.4.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.4/java_tools_linux-v13.4.zip",
      "sha": "ba10f09a138cf185d04cbc807d67a3da42ab13d618c5d1ce20d776e199c33a39"
    },
    "java_tools_windows": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.4/java_tools_windows-v13.4.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.4/java_tools_windows-v13.4.zip",
      "sha": "fe2f88169696d6c6fc6e90ba61bb46be7d0ae3693cbafdf336041bf56679e8d1"
    },
    "java_tools_darwin_x86_64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.4/java_tools_darwin_x86_64-v13.4.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.4/java_tools_darwin_x86_64-v13.4.zip",
      "sha": "4523aec4d09c587091a2dae6f5c9bc6922c220f3b6030e5aba9c8f015913cc65"
    },
    "java_tools_darwin_arm64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.4/java_tools_darwin_arm64-v13.4.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.4/java_tools_darwin_arm64-v13.4.zip",
      "sha": "076a7e198ad077f8c7d997986ef5102427fae6bbfce7a7852d2e080ed8767528"
    },
    "java_tools": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.4/java_tools-v13.4.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.4/java_tools-v13.4.zip",
      "sha": "e025fd260ac39b47c111f5212d64ec0d00d85dec16e49368aae82fc626a940cf"
    }
  }
}

Step 10:
java_tools released: https://github.com/bazelbuild/java_tools/releases/tag/java_v13.4

Step 11:
rules_java PR: bazelbuild/rules_java#168

Step 12:
rules_java released: https://github.com/bazelbuild/rules_java/releases/tag/7.4.0
BCR PR: bazelbuild/bazel-central-registry#1453

copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Feb 14, 2024
bazelbuild/java_tools#87

Closes #21222.

PiperOrigin-RevId: 606887265
Change-Id: I45a32ccb1f9aea3511a82d346cbaeab9bd8cd6ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) release
Projects
None yet
Development

No branches or pull requests

5 participants