Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang: Display Go external libraries based on importpath structure (bazelbuild/intellij PR import #2973) #3833

Merged
merged 0 commits into from
Aug 12, 2022

Conversation

copybara-service[bot]
Copy link

Golang: Display Go external libraries based on importpath structure (bazelbuild/intellij PR import #2973)

This is a modified version of the original change by Brandon Lico with a few modifications:

  • read from the fileToImportPathMap directly when modifying the structure
  • add unit tests.

Design choices:

  • We don't inherit from BlazeExternalSyntheticLibrary since that contains irrelevant logic. Also we can't logically fulfill the "Only supports one instance per value of presentableText." condition that's outlined in the class javadoc since we could have nodes with identical presentableText properties in the tree in different positions.

Discussion thread for this change

Issue number: #1744 #2365

Description of this change

Modifies the structure of the external "Go Libraries" project view to be based on importpath rather than a flat list of files. See my comment within #2365 for an example of how the new structure looks.

Closes #2973

Tests

Unit tests added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants