go_default_library should not be a go_proto_library #1184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naming this: https://github.com/bazelbuild/buildtools/blob/master/build_proto/BUILD.bazel#L22
go_default_library
is causing issues:We should not be calling a
go_proto_library(
go_default_library
because it prevents adding the alias. See theapi_proto
file as an example: https://github.com/bazelbuild/buildtools/blob/master/api_proto/BUILD.bazel