Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_default_library should not be a go_proto_library #1184

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

tyler-french
Copy link
Contributor

naming this: https://github.com/bazelbuild/buildtools/blob/master/build_proto/BUILD.bazel#L22 go_default_library is causing issues:

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
link: package conflict error: github.com/bazelbuild/buildtools/lang: package imports github.com/bazelbuild/buildtools/build_proto
          was compiled with: @@gazelle~override~go_deps~com_github_bazelbuild_buildtools//build_proto:build_proto
        but was linked with: @@gazelle~override~go_deps~com_github_bazelbuild_buildtools//build_proto:go_default_library
See https://github.com/bazelbuild/rules_go/issues/1877.

We should not be calling a go_proto_library( go_default_library because it prevents adding the alias. See the api_proto file as an example: https://github.com/bazelbuild/buildtools/blob/master/api_proto/BUILD.bazel

@vladmos
Copy link
Member

vladmos commented Aug 22, 2023

cc @fmeum

@vladmos vladmos merged commit 691e01a into bazelbuild:master Aug 23, 2023
2 checks passed
apattidb pushed a commit to databricks/buildtools that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants