Allow external top-level dir in Bzlmod-managed non-main repos
#24126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
external-external-pkg
branch
from
868c0a2
to
869f3ab
Compare
fmeum
changed the title
//external package in non-main repos//external package in Bzlmod-managed non-main repos
fmeum
force-pushed
the
external-external-pkg
branch
from
869f3ab
to
facafaf
Compare
fmeum
changed the title
//external package in Bzlmod-managed non-main reposexternal top-leve dir in Bzlmod-managed non-main repos
fmeum
changed the title
external top-leve dir in Bzlmod-managed non-main reposexternal top-level dir in Bzlmod-managed non-main repos
fmeum
force-pushed
the
external-external-pkg
branch
from
facafaf
to
0ca0334
Compare
fmeum
requested review from
gregestren,
Wyverald and
meteorcloudy
and removed request for
a team and
gregestren
github-actions
bot
added
team-Configurability
fmeum
force-pushed
the
external-external-pkg
branch
from
0ca0334
to
32fe545
Compare
fmeum
commented
Oct 29, 2024
src/main/java/com/google/devtools/build/lib/skyframe/ProcessPackageDirectory.java
Show resolved
Hide resolved
Wyverald
approved these changes
Oct 29, 2024
src/main/java/com/google/devtools/build/lib/skyframe/ProcessPackageDirectory.java
Show resolved
Hide resolved
Wyverald
added
team-ExternalDeps
|
@Wyverald Could this go into Bazel 8? If not, can I already mark it for 8.1.0? It would make some relevant Go modules buildable with Bazel. |
Wyverald
added
awaiting-PR-merge
meteorcloudy
approved these changes
Oct 30, 2024
|
Let's do it for 8.0.0 |
|
@bazel-io fork 8.0.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 30, 2024
Also remove an unused method. RELNOTES: External repositories that are managed by Bzlmod can now contain a top-level `external` directory or package. Closes bazelbuild#24126. PiperOrigin-RevId: 691521324 Change-Id: I84d11f2163ce5a6e34578afb6a2cc9793d78f0b1
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
…os (#24147) Also remove an unused method. RELNOTES: External repositories that are managed by Bzlmod can now contain a top-level `external` directory or package. Closes #24126. PiperOrigin-RevId: 691521324 Change-Id: I84d11f2163ce5a6e34578afb6a2cc9793d78f0b1 Commit 0e2bcda Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove an unused method.
RELNOTES: External repositories that are managed by Bzlmod can now contain a top-level
externaldirectory or package.