Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0] Rename stripPrefix= to strip_prefix= #24035

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

bazel-io
Copy link
Member

Fixes #16496

Closes #24019.

RELNOTES: The stripPrefix parameter of repository_ctx.download_and_extract()
and repository_ctx.extract() has been renamed to strip_prefix; the deprecated
stripPrefix name remains usable for compatibility.
PiperOrigin-RevId: 687224164
Change-Id: Iffaba2e65c049a2ff8bb98d1fba52e0bba9e5a02

Commit 49d7bb6

Fixes bazelbuild#16496

Closes bazelbuild#24019.

RELNOTES: The stripPrefix parameter of repository_ctx.download_and_extract()
and repository_ctx.extract() has been renamed to strip_prefix; the deprecated
stripPrefix name remains usable for compatibility.
PiperOrigin-RevId: 687224164
Change-Id: Iffaba2e65c049a2ff8bb98d1fba52e0bba9e5a02
@bazel-io bazel-io requested a review from a team as a code owner October 18, 2024 11:04
@bazel-io bazel-io added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Oct 18, 2024
@meteorcloudy meteorcloudy added this pull request to the merge queue Oct 18, 2024
@fmeum
Copy link
Collaborator

fmeum commented Oct 18, 2024

@meteorcloudy Is a new RC for 7.4.0 planned? If so, we could cherry-pick this, otherwise it's probably not worth it.

Merged via the queue into bazelbuild:release-8.0.0 with commit 2331861 Oct 18, 2024
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants