-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.4.0] Apply single_version_override
patches to module files
#23757
Conversation
single_version_override
patches to module filessingle_version_override
patches to module files
Work towards bazelbuild#19301 RELNOTES: Patches to the module file in `single_version_override` are now effective as long as the patch file lies in the root module. Closes bazelbuild#23536. PiperOrigin-RevId: 678347809 Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
33a2025
Thank you for adding this feature. A question, how does it work when there are multiple versions of the same module? As I understood, patching happens before resolution, so it is unclear to users which version it is patching against, and the patch file the user has prepared may not be valid. I have a concrete case where multiple versions grpc-java get pulled in. I want to patch against 1.66.0, but after debugging the patching process I realized the patch was against another version, and that of course failed. Is this an unsupported use case? |
@honnix If you want to patch a specific version, then you (probably) also want to have that version selected. You can achieve that by setting |
Ah, of course 🤦 . Thank you for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fmeum:23605-cherry
Work towards #19301
RELNOTES: Patches to the module file in
single_version_override
are now effective as long as the patch file lies in the root module.Closes #23536.
PiperOrigin-RevId: 678347809
Change-Id: I6a3c4664e55cff90c8e42795f95d8ef211348ca9
Closes #23605