Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] Fix genrule autostamping in bazel #21512

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[7.1.0] Fix genrule autostamping in bazel #21512

merged 2 commits into from
Feb 28, 2024

Commits on Feb 27, 2024

  1. Clean up GenRuleBase in preparation for merging bazelbuild#21407. 

    Isolate two `@ForOverride` methods and make everything else `private` to make it clear what behavior may diverge between bazel and blaze.

PiperOrigin-RevId: 608999251
Change-Id: I16343d4a1b538d9c13544661ec421f13bf9b1c40
    @justinhorvitz @iancha1992
    justinhorvitz authored and iancha1992 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    524c49c View commit details
    Browse the repository at this point in the history

  2. Fix genrule autostamping in bazel 

    Genrule does not support conditional stamping based on the value of the `--stamp` flag. This is because genrule treats the `stamp` attribute as `boolean`, while all other rules use the `tristate` type. After this change, the stamp attribute in genrule can be set to `-1` to request conditional stamping.

RELNOTES: `genrule` now supports setting `stamp = -1` to request conditional stamping (based on the value of the build's `--stamp` flag).

Closes bazelbuild#21407.

PiperOrigin-RevId: 609085052
Change-Id: I873941e9aaae3760a545c1900cd13cb60a9ada39
    @AlessandroPatti @iancha1992
    AlessandroPatti authored and iancha1992 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3f64fa5 View commit details
    Browse the repository at this point in the history