[7.1.0] Fix stale trash dir not cleaned up on worker creation #21511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug in Blaze is that ${output_base}/blaze-workers/_moved_trash_dir/ doesn't
get wiped between blaze restarts. The directory to move to for asynchronous
deletion is an incrementing AtomicInteger but after a restart it will be zero
again. If there were previous directories there, we might get an error trying
to replace a non-empty directory while renaming.
RELNOTES:none
PiperOrigin-RevId: 610323627
Change-Id: I2d397fbd4590fa9f83273ac11d92d591bf9348b8
github-actions
bot
added
awaiting-review
oquenchil
approved these changes
Feb 27, 2024
|
Closing this in favour of #21510 (just noticed that one :)) |
auto-merge was automatically disabled
February 27, 2024 18:55
Pull request was closed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug in Blaze is that ${output_base}/blaze-workers/_moved_trash_dir/ doesn't get wiped between blaze restarts. The directory to move to for asynchronous deletion is an incrementing AtomicInteger but after a restart it will be zero again. If there were previous directories there, we might get an error trying to replace a non-empty directory while renaming.
Commit e482e8b
RELNOTES:none
PiperOrigin-RevId: 610323627
Change-Id: I2d397fbd4590fa9f83273ac11d92d591bf9348b8