Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][windows] Export BAZEL_TEST=1 on windows #21444

Closed
wants to merge 6 commits into from

Conversation

cristiandonosoc
Copy link
Contributor

This was an oversight from when exporting BAZEL_TEST on Linux.

fixes: #21420

This was an oversight from when exporting BAZEL_TEST on Linux.

fixes: bazelbuild#21420
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 21, 2024
@cristiandonosoc
Copy link
Contributor Author

I searched on https://github.com/bazelbuild/bazel/blob/4e43b4aaa3a0f85a6390326e245c675c091c965b/tools/test/windows/tw_test.cc to see how could I test this, but those are not blackbox run a subprocess and see what env variables were actually sent type of tests.

Maybe that test is somewhere but I couldn't find it. If you could point me to it, I could perhaps add the test?

@sgowroji sgowroji added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 21, 2024
An oversight, test pass now
@cristiandonosoc
Copy link
Contributor Author

Sorry for the messy CLs, but I don't want to install Java (and the other toolchains that might be required) just for this, so I'm abusing the CI a bit to run the tests for me.
I didn't find info about Bazel distributing the toolchains required. Perhaps if there is a way you could point me to it?

Now we correctly query for the env variable
@cristiandonosoc
Copy link
Contributor Author

Okay I stopped being lazy and figured how to run the tests locally (--java_runtime_version=remotejdk_11).
Now it has an actual test verifying that we're supplying the BAZEL_TEST env variable.

Sorry for the spam.

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Feb 22, 2024
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 22, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 26, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 26, 2024
This was an oversight from when exporting BAZEL_TEST on Linux.

fixes: bazelbuild#21420

Closes bazelbuild#21444.

PiperOrigin-RevId: 610338496
Change-Id: Icbbdc42b6ea92a2de2b0c558aea47a24493c9d8a
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
This was an oversight from when exporting BAZEL_TEST on Linux.

fixes: #21420

Closes #21444.

Commit
0a9d612

PiperOrigin-RevId: 610338496
Change-Id: Icbbdc42b6ea92a2de2b0c558aea47a24493c9d8a

Co-authored-by: Cristin Donoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAZEL_TEST env variable is not sent on Windows
4 participants