Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.1.0] Don't use worker threads for repo fetching during Skyframe er… #21305

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[7.1.0] Don't use worker threads for repo fetching during Skyframe er… #21305

merged 1 commit into from
Feb 12, 2024

Commits on Feb 12, 2024

  1. [7.1.0] Don't use worker threads for repo fetching during Skyframe er… 

    …ror bubbling

For some reason, using worker threads for repo fetching during Skyframe error bubbling frequently causes deadlocks on Linux. I wasn't able to find out why the deadlock happens, but this CL is the immediate solution to the problem, and shouldn't be a performance concern since no Skyframe restarts should happen during error bubbling anyway.

Tested on Linux; with this CL, `bazel test //src/test/shell/bazel:starlark_repository_test --test_filter=test_download_failure_message --runs_per_test=20` finishes just fine. (On an M1 macbook, I can't trigger the deadlock even without this CL.)

Fixes #21238

PiperOrigin-RevId: 606305306
Change-Id: I6f47a144b29030011f6c10c2b37f6874190fed0e
    @Wyverald
    Wyverald committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b4dcdc2 View commit details
    Browse the repository at this point in the history