Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] Fix two issues with --incompatible_sandbox_hermetic_tmp that manifested themselves when the output base was under /tmp #20766

Merged

Commits on Jan 5, 2024

  1. Fix two issues with --incompatible_sandbox_hermetic_tmp that manife…

    …sted themselves when the output base was under `/tmp`:
    
    1. Virtual action inputs didn't work. This was a fairly simple omission in the path transformation logic.
    2. Artifacts which are resolved symlinks (i.e. declared using `declare_file`) did not work. This is fixed by keeping track of the realpath of the symlink in `FileArtifactValue` / `TreeArtifactValue`.
    
    Fixes bazelbuild#20515 and bazelbuild#20518.
    
    RELNOTES: None.
    PiperOrigin-RevId: 595145191
    Change-Id: I833025928374c78bc719d8e3be1efb2b2950b9f1
    lberki authored and bazel-io committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    88d05f3 View commit details
    Browse the repository at this point in the history