Add support for tmpfs mounts under /tmp with hermetic tmp
#20658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bazel-io fork 7.1.0 |
github-actions
bot
added
team-Local-Exec
fmeum
force-pushed
the
20527-tmpfs-under-tmp
branch
3 times, most recently
from
91b8da5
to
6e949fe
Compare
sgowroji
added
awaiting-user-response
lberki
approved these changes
Jan 2, 2024
lberki
added
awaiting-PR-merge
fmeum
force-pushed
the
20527-tmpfs-under-tmp
branch
from
6e949fe
to
352e75b
Compare
lberki
approved these changes
Jan 2, 2024
|
@lberki Do you want me to resolve the merge conflict in the tests or are you taking care of this during the import? |
fmeum
force-pushed
the
20527-tmpfs-under-tmp
branch
from
352e75b
to
161a884
Compare
This is achieved by mounting tmpfs after regular mounts in the sandbox binary as well as creating the directories at which tmpfs are mounted under the sandbox tmp directory.
fmeum
force-pushed
the
20527-tmpfs-under-tmp
branch
from
161a884
to
fa3f6c5
Compare
|
@iancha1992 Resolved |
|
@fmeum thanks for rebasing; I was about to say "I'd appreciate if you did it because today just became extraordinarily complicated for me", but you were even acausal :) (I already approved the internal change, it's grinding its way through our submit process) |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 11, 2024
This is achieved by mounting tmpfs after regular mounts in the sandbox binary as well as creating the directories at which tmpfs are mounted under the sandbox tmp directory. Closes bazelbuild#20658. PiperOrigin-RevId: 595500822 Change-Id: Icf3d51bffdd004f668ba4fbbdbd5f833c20db3d9
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…20859) This is achieved by mounting tmpfs after regular mounts in the sandbox binary as well as creating the directories at which tmpfs are mounted under the sandbox tmp directory. Closes #20658. Commit 620d617 PiperOrigin-RevId: 595500822 Change-Id: Icf3d51bffdd004f668ba4fbbdbd5f833c20db3d9 Co-authored-by: Fabian Meumertzheim <[email protected]>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by mounting tmpfs after regular mounts in the sandbox binary as well as creating the directories at which tmpfs are mounted under the sandbox tmp directory.