-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable import_deps_checker tests in Bazel #20655
Conversation
438b0d2
to
0f5e983
Compare
@cushon The darwin runner failures seem to be unrelated and also affect other PRs. |
We are upgrading our macOS machines this week, sorry for those CI failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
src/java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/BUILD
Outdated
Show resolved
Hide resolved
b67c7fa
to
c96dbb3
Compare
@sgowroji I fixed the tests by rebasing. |
A compatible JDK 8 is fetched via `remote_java_repository`. Requires fixing paths in golden files to not contain `third_party/bazel/` as well as the expected exit code of the `MethodHandle#invoke` test, which is expected to pass.
c96dbb3
to
d80ec92
Compare
@meteorcloudy I resolved the conflict in the lockfile. |
@meteorcloudy Friendly ping |
@iancha1992 @sgowroji How is this one ignored? Anything wrong with your filter for PRs ready to be imported? |
...java_tools/import_deps_checker/javatests/com/google/devtools/build/importdeps/golden_test.sh
Show resolved
Hide resolved
There was an import in progress as cl/597295954, but it was blocked on test failures. |
Looks like the tests are now going through after your changes. I'll try to merge then now. Can you LGTM cl/597295954 @meteorcloudy cc: @fmeum |
A compatible JDK 8 is fetched via `remote_java_repository`. Requires fixing paths in golden files to not contain `third_party/bazel/` as well as the expected exit code of the `MethodHandle#invoke` test, which is expected to pass. Fixes bazelbuild#8162 Closes bazelbuild#20655. PiperOrigin-RevId: 602641568 Change-Id: I54ec568d981e3bd27caab9e24c0c9eb2a25c6372
A compatible JDK 8 is fetched via
remote_java_repository
. Requires fixing paths in golden files to not containthird_party/bazel/
as well as the expected exit code of theMethodHandle#invoke
test, which is expected to pass.Fixes #8162