Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] Remove unnecessary cc_test coverage handling #20641

Merged
merged 2 commits into from
Jan 9, 2024

Commits on Dec 21, 2023

  1. Remove unnecessary cc_test coverage handling

    Both the `lcov_merger` and the `collect_cc_coverage` script are obtained from "well-known" implicit attributes of Starlark rules and do not require any further special handling.
    
    Removing this special handling also fixes a fringe bug: When a `cc_test` is wrapped in another test target that applies a transition to it, the removed logic set the `LCOV_MERGER` variable to the untransitioned path of the `lcov_merger`, which will then not be available in the test sandbox since it is only added as a runfile, but the test action references it via its exec path. This resulted in a "file not found" error that broke coverage.
    
    Closes bazelbuild#20349.
    
    PiperOrigin-RevId: 589252093
    Change-Id: I810f1b414dcfedcc8930a74390ef5c9bfd2cd030
    fmeum authored and bazel-io committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    45cad91 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    65fa642 View commit details
    Browse the repository at this point in the history