Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read authentication information from .netrc #20417

Closed
wants to merge 5 commits into from
Closed

Conversation

guw
Copy link
Contributor

@guw guw commented Dec 2, 2023

Workaround for #13709

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 2, 2023
tools/build_defs/repo/jvm.bzl Outdated Show resolved Hide resolved
@sgowroji sgowroji added awaiting-user-response Awaiting a response from the author team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 4, 2023
@meteorcloudy
Copy link
Member

We are using http_archive directly from the bazel repo at

load("//tools/build_defs/repo:http.bzl", "http_archive", "http_file")
instead of from @bazel_tools.

So the lockfile has to be updated.

@guw
Copy link
Contributor Author

guw commented Dec 4, 2023

So the lockfile has to be updated.

Should I do this in this PR?
Are there instructions?

@meteorcloudy
Copy link
Member

Please run bazel mod deps --lockfile_mode=update to update your lockfile.

Just follow the error message. You probably also need to run

# NOTE: When editing this file, also update the lockfile.
# bazel run //src/test/tools/bzlmod:update_default_lock_file
# bazel mod deps --lockfile_mode=update

@guw
Copy link
Contributor Author

guw commented Dec 4, 2023

Updated the lock files. Can someone review if this is good?

@meteorcloudy
Copy link
Member

The lockfile changes should be good. But can you check the test failure?

https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/018c3658-6f74-40ff-b908-b0b49b7c0687/src/test/shell/bazel/external_integration_test/shard_9_of_15/test_attempts/attempt_2.log

ERROR: Evaluation of query "deps(//zoo:ball-pit)" failed: preloading transitive closure failed: no such package '@@endangered//jar': No such attribute 'netrc'

@guw guw force-pushed the patch-1 branch 2 times, most recently from 8c81948 to 60018d7 Compare December 5, 2023 16:24
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-user-response Awaiting a response from the author labels Dec 6, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2023
@iancha1992
Copy link
Member

@bazel-io fork 7.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2023
@copybara-service copybara-service bot closed this in ce8bd90 Dec 7, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 7, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2024
Workaround for #13709

Closes #20417.
Commit
ce8bd90

PiperOrigin-RevId: 588762567
Change-Id: Ie02d7ff6ffaad646bf67059bebc7e0d5894f079e

Co-authored-by: Gunnar Wagenknecht <[email protected]>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants