Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fedora39 to CI platforms #20405

Closed
wants to merge 1 commit into from

Conversation

davido
Copy link
Contributor

@davido davido commented Dec 1, 2023

Fedora 39 is shipping GCC 13, modern C/C++ toolchain, so that adding it to CI platforms would help to detect breakages earlier, that related to modern C/C++ toolchains.

@davido
Copy link
Contributor Author

davido commented Dec 1, 2023

//CC @meteorcloudy

This is related to bazelbuild/continuous-integration#1593 and bazelbuild/continuous-integration#1639.

Is this the right approach to verify Bazel itself on Fedora 39, like we did for gerrit pipeline recently?

@sgowroji sgowroji added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website awaiting-review PR is awaiting review from an assigned reviewer labels Dec 1, 2023
@meteorcloudy
Copy link
Member

You'll have to also add the same config in the presubmit.yml file.

I'm fine with testing on fedora 39, but can we only test building Bazel itself and exclude running all tests? Since we have limited CI resources and running the whole test suite is quite expensive.

@meteorcloudy meteorcloudy self-requested a review December 1, 2023 10:57
@davido
Copy link
Contributor Author

davido commented Dec 1, 2023

You'll have to also add the same config in the presubmit.yml file.

Done.

I'm fine with testing on fedora 39, but can we only test building Bazel itself and exclude running all tests?

Done.

@davido davido force-pushed the bazel-add-fedora39-platform branch from cec510d to 0d300fc Compare December 1, 2023 17:10
.bazelci/postsubmit.yml Outdated Show resolved Hide resolved
Fedora39 is shipping GCC 13, modern C/C++ toolchain, so that adding it
to CI platforms would help to detect breakages earlier, that related to
modern C/C++ toolchains.
@davido davido force-pushed the bazel-add-fedora39-platform branch from 0d300fc to 743f573 Compare December 4, 2023 13:09
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 4, 2023
@copybara-service copybara-service bot closed this in 5c9be19 Dec 4, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 4, 2023
Wyverald pushed a commit that referenced this pull request Jan 3, 2024
Fedora 39 is shipping GCC 13, modern C/C++ toolchain, so that adding it to CI platforms would help to detect breakages earlier, that related to modern C/C++ toolchains.

Closes #20405.

PiperOrigin-RevId: 587697147
Change-Id: Ib5adf1579991a85f1e2994fb86b1b9e7b25bad7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants