[7.0.0] Fix cc_shared_library error with hdr-only libraries #20228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*** Reason for rollback *** Rollforward of bafc72e *** Original change description *** Fix cc_shared_library error with hdr-only libraries cc_libraries with a linker_input with no libraries (either because they contain only headers or only linkopts) caused errors in cc_shared_libraries triggered by a check that made sure that a cc_library wasn't linked more than once into different shared libraries. That check can be ignored in those cases. RELNOTES:none *** Fixes #19920 PiperOrigin-RevId: 583033207 Change-Id: I227021f33596dbc5a6708fa5a705803094f24665
github-actions
bot
added
the
awaiting-review
meteorcloudy
approved these changes
Nov 16, 2023
iancha1992
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cc_shared_library error with hdr-only libraries
cc_libraries with a linker_input with no libraries (either because they contain only headers or only linkopts) caused errors in cc_shared_libraries triggered by a check that made sure that a cc_library wasn't linked more than once into different shared libraries. That check can be ignored in those cases.
RELNOTES:none
Fixes #19920
Commit 886b13f
PiperOrigin-RevId: 583033207
Change-Id: I227021f33596dbc5a6708fa5a705803094f24665