Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the attr new_local_repository.build_file label-typed #19992

Closed
wants to merge 4 commits into from
Closed

Make the attr new_local_repository.build_file label-typed #19992

wants to merge 4 commits into from

Commits on Oct 30, 2023

  1. Make the attr new_local_repository.build_file label-typed 

    The attribute is string-typed to support a legacy use case where a path instead of a label could be passed. This causes us to parse a passed label as a canonical label, forgoing repo mapping altogether.

Fixes #19963.

RELNOTES[INC]: The attribute `new_local_repository.build_file` no longer accepts a path; a label must be passed instead.
    @Wyverald
    Wyverald committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    332c5e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. add test & address comments

    @Wyverald
    Wyverald committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c1670ad View commit details
    Browse the repository at this point in the history

  2. moar test fixes & more helpful error message

    @Wyverald
    Wyverald committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4ab178e View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. add a comment

    @Wyverald
    Wyverald committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    2b1dfb6 View commit details
    Browse the repository at this point in the history