Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include actual MODULE.bazel location in stack traces #18572

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 4, 2023

Instead of <name>@<version>/MODULE.bazel, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL.

@fmeum fmeum changed the title Include root MODULE.bazel path in stack trace Include actual MODULE.bazel location in stack traces Jun 4, 2023
@fmeum fmeum force-pushed the fix-root-stack-trace branch 3 times, most recently from 61c46d9 to 7ab4eda Compare June 4, 2023 10:35
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a
MODULE.bazel file is now reported in stack traces, either as a file path
or a URL.
@fmeum fmeum force-pushed the fix-root-stack-trace branch from 7ab4eda to ec8a76c Compare June 4, 2023 11:07
@fmeum fmeum marked this pull request as ready for review June 4, 2023 11:22
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jun 4, 2023
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, thanks! this is so much better than what we had!

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 7, 2023
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚💚💚

@copybara-service copybara-service bot closed this in 2659f49 Jun 7, 2023
@Wyverald
Copy link
Member

Wyverald commented Jun 7, 2023

@bazel-io fork 6.3.0

iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 7, 2023
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL.

Closes bazelbuild#18572.

PiperOrigin-RevId: 538597414
Change-Id: I038e070d9bd4397bba2ed491597cadd0b56d6481
@iancha1992 iancha1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 7, 2023
iancha1992 added a commit that referenced this pull request Jun 7, 2023
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL.

Closes #18572.

PiperOrigin-RevId: 538597414
Change-Id: I038e070d9bd4397bba2ed491597cadd0b56d6481

Co-authored-by: Fabian Meumertzheim <[email protected]>
@fmeum fmeum deleted the fix-root-stack-trace branch June 8, 2023 22:22
traversaro pushed a commit to traversaro/bazel that referenced this pull request Jun 24, 2023
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL.

Closes bazelbuild#18572.

PiperOrigin-RevId: 538597414
Change-Id: I038e070d9bd4397bba2ed491597cadd0b56d6481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants