-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include actual MODULE.bazel location in stack traces #18572
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
changed the title
Include root MODULE.bazel path in stack trace
Include actual MODULE.bazel location in stack traces
Jun 4, 2023
fmeum
force-pushed
the
fix-root-stack-trace
branch
3 times, most recently
from
June 4, 2023 10:35
61c46d9
to
7ab4eda
Compare
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL.
fmeum
force-pushed
the
fix-root-stack-trace
branch
from
June 4, 2023 11:07
7ab4eda
to
ec8a76c
Compare
github-actions
bot
added
awaiting-review
PR is awaiting review from an assigned reviewer
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
labels
Jun 4, 2023
Wyverald
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, thanks! this is so much better than what we had!
Wyverald
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Jun 7, 2023
meteorcloudy
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚💚💚
@bazel-io fork 6.3.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 7, 2023
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL. Closes bazelbuild#18572. PiperOrigin-RevId: 538597414 Change-Id: I038e070d9bd4397bba2ed491597cadd0b56d6481
iancha1992
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Jun 7, 2023
iancha1992
added a commit
that referenced
this pull request
Jun 7, 2023
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL. Closes #18572. PiperOrigin-RevId: 538597414 Change-Id: I038e070d9bd4397bba2ed491597cadd0b56d6481 Co-authored-by: Fabian Meumertzheim <[email protected]>
traversaro
pushed a commit
to traversaro/bazel
that referenced
this pull request
Jun 24, 2023
Instead of `<name>@<version>/MODULE.bazel`, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL. Closes bazelbuild#18572. PiperOrigin-RevId: 538597414 Change-Id: I038e070d9bd4397bba2ed491597cadd0b56d6481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
<name>@<version>/MODULE.bazel
, the actual location of a MODULE.bazel file is now reported in stack traces, either as a file path or a URL.