Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --experimental_remote_grpc_log to --remote_grpc_log #18180

Closed
wants to merge 1 commit into from
Closed

Rename --experimental_remote_grpc_log to --remote_grpc_log #18180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,11 @@ public void beforeCommand(CommandEnvironment env) throws AbruptExitException {
}

ClientInterceptor loggingInterceptor = null;
if (remoteOptions.experimentalRemoteGrpcLog != null) {
if (remoteOptions.remoteGrpcLog != null) {
try {
rpcLogFile =
new AsynchronousFileOutputStream(
env.getWorkingDirectory().getRelative(remoteOptions.experimentalRemoteGrpcLog));
env.getWorkingDirectory().getRelative(remoteOptions.remoteGrpcLog));
} catch (IOException e) {
handleInitFailure(env, e, Code.RPC_LOG_FAILURE);
return;
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,8 @@ public RemoteBuildEventUploadModeConverter() {
public boolean experimentalGuardAgainstConcurrentChanges;

@Option(
name = "experimental_remote_grpc_log",
name = "remote_grpc_log",
werkt marked this conversation as resolved.
Show resolved Hide resolved
oldName = "experimental_remote_grpc_log",
defaultValue = "null",
category = "remote",
documentationCategory = OptionDocumentationCategory.REMOTE,
Expand All @@ -391,7 +392,7 @@ public RemoteBuildEventUploadModeConverter() {
+ "protobufs with each message prefixed by a varint denoting the size of the"
+ " following serialized protobuf message, as performed by the method "
+ "LogEntry.writeDelimitedTo(OutputStream).")
public PathFragment experimentalRemoteGrpcLog;
public PathFragment remoteGrpcLog;

@Option(
name = "incompatible_remote_symlinks",
Expand Down