add externalInclude information to compilation_context #18094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
sgowroji
added
the
team-Configurability
gregestren
added
team-Rules-CPP
|
@buildbreaker2021 Friendly ping |
oquenchil
approved these changes
Jul 3, 2023
oquenchil
added
awaiting-PR-merge
|
Everything is failing on CI when triggering OSS presubmits internally: https://buildkite.com/bazel/google-bazel-presubmit/builds/68979#01891f2d-392a-42eb-bde3-ddb81d13e7b9 |
… implement aspects correctly)
|
I rebased the changes |
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi bazel team
I use an aspect to run clangtidy on the codebase. It is based on https://github.com/erenon/bazel_clang_tidy.
To check my codebase with
-Werror, I use the "new" featureexternal_include_pathrequested by #12009, introduced by commit 08936ae.Now my clangtidy rules did not work anymore of course. As you can see in https://github.com/erenon/bazel_clang_tidy/blob/master/clang_tidy/clang_tidy.bzl, all the different include paths are being passed to the clang-tidy executable. I now also needed to pass the new external_includes to
clang-tidy.This PR adds
external_includesto thecompilation_contextobject. I looked at the style of the otherincludesand hope it is in line with your expectations.