Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include --bes_upload_mode in docs #17876

Closed

Conversation

keith
Copy link
Member

@keith keith commented Mar 24, 2023

No description provided.

@sgowroji sgowroji added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Mar 24, 2023
brentleyjones
brentleyjones previously approved these changes Mar 24, 2023
@brentleyjones brentleyjones dismissed their stale review March 24, 2023 14:04

Didn't know it would be green. Leaving it for remote execution team to approve.

@keertk keertk requested a review from a team March 24, 2023 14:16
@keertk keertk added team-Remote-Exec Issues and PRs for the Execution (Remote) team and removed team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Mar 24, 2023
@keith keith force-pushed the ks/include-bes_upload_mode-in-docs branch from 77c1661 to ecf4b76 Compare March 27, 2023 16:58
@keith
Copy link
Member Author

keith commented Mar 28, 2023

i think there are some flaky tests @ HEAD since this shouldn't affect anything

@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 29, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 29, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Closes bazelbuild#17876.

PiperOrigin-RevId: 520324506
Change-Id: I98125fc6fb095c13a8386245af91923b7bdf5905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants