Include generated code in instrumented files #17556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Configurability
katre
added
team-Rules-CPP
|
Redundant after #11350 |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using a code generator that replaces the source code with generated code before feeding to the compiler. We are collecting the code coverage on the generated code so we can map it back to the original source code.
This was possible before Bazel 6, but started to fail after Bazel 6 because it comes with a newer version of coverage_output_generator, which ignores files not included in
coverage_common.instrumented_files_info.This PR makes
coverage_common.instrumented_files_inforeturn both regular and generated/derived source files.