Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java coverage collection with Java 8 runtime #17338

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 26, 2023

JacocoCoverageRunner is run with the target runtime, not the exec runtime, and thus needs to be compatible with a Java 8 runtime.

Fixes #17165

`JacocoRunner` is run with the target runtime, not the exec runtime, and
thus needs to be compatible with a Java 8 runtime.
@fmeum fmeum changed the title WIP: Fix coverage with Java 8 Fix Java coverage collection with Java 8 runtime Jan 26, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 26, 2023

I confirmed locally that the issue is fixed. Setting up an integration test for this would require JDK 8 to be available in CI, which as far as I can tell isn't available on most CI runners anymore.

@fmeum fmeum marked this pull request as ready for review January 26, 2023 20:14
@fmeum fmeum requested a review from lberki as a code owner January 26, 2023 20:14
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 26, 2023

@cushon Could you review?

@cushon cushon requested a review from comius January 26, 2023 20:55
@cushon
Copy link
Contributor

cushon commented Jan 26, 2023

This makes sense to me.

I'm not sure how owns this stuff, @comius is there anyone you want to loop in for this?

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 26, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 26, 2023
@ShreeM01 ShreeM01 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 26, 2023
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 30, 2023
@comius comius requested a review from c-mita February 7, 2023 12:31
@comius comius removed the request for review from lberki February 7, 2023 12:32
@comius
Copy link
Contributor

comius commented Feb 7, 2023

LGTM from my side, but WANT_LGTM=c-mita also

@fmeum
Copy link
Collaborator Author

fmeum commented Feb 7, 2023

@c-mita just in case

Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Optional<ImmutableSet>::isEmpty was confusing anyway.

@hvadehra hvadehra added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 9, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 13, 2023
@fmeum fmeum deleted the fix-java8-coverage branch February 14, 2023 07:43
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
`JacocoCoverageRunner` is run with the target runtime, not the exec runtime, and thus needs to be compatible with a Java 8 runtime.

Fixes #17165

Closes #17338.

PiperOrigin-RevId: 509123073
Change-Id: I41d7255e1f3c3dd3864082899d5dc9ab2cc82027
ShreeM01 added a commit that referenced this pull request Feb 15, 2023
`JacocoCoverageRunner` is run with the target runtime, not the exec runtime, and thus needs to be compatible with a Java 8 runtime.

Fixes #17165

Closes #17338.

PiperOrigin-RevId: 509123073
Change-Id: I41d7255e1f3c3dd3864082899d5dc9ab2cc82027

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel 6.0.0 Java 8 Coverage Broken
8 participants