Do not clear --platforms on no-op change to --cpu
#17158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
Jan 6, 2023
Due to a Bazel issue (bazelbuild/bazel#17158), the recent introduction of `universal_binary` ended up forking the configuration for dependencies of the Jazzer launcher. As a result, some Java targets were built twice and the Docker images failed to build as the Jazzer standalone jar was no longer a dependency of the launcher in the default configuration. As a workaround and also because it prevents similar issues on a more fundamental level, switch to the soon to be default improved config hash algorithm.
|
@gregestren Could you take a look? This resolves a build time regressions we had when we picked up rules_apple's |
Resolves a TODO in the code to not unnecessarily fork the configuration when a transition has `--cpu` as a declared output but doesn't change it.
fmeum
force-pushed
the
fix-cpu-no-op-not-fully-no-op
branch
from
7a65c45 to
57fc3d2
Compare
katre
requested changes
Jan 6, 2023
| .build() | ||
| : originalOutput; | ||
| BuildOptions options, Map<String, Object> originalOutput) { | ||
| Object newCpu = originalOutput.get(COMMAND_LINE_OPTION_PREFIX + "cpu"); |
There was a problem hiding this comment.
Nit: The names newCpu and originalOutput don't seem to match. Can we rename one of them?
There was a problem hiding this comment.
Done, renamed the existing variable to be more descriptive.
src/test/java/com/google/devtools/build/lib/analysis/StarlarkAttrTransitionProviderTest.java
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/analysis/StarlarkAttrTransitionProviderTest.java
Show resolved
Hide resolved
katre
approved these changes
Jan 6, 2023
katre
added
team-Configurability
fmeum
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
Jan 7, 2023
Due to a Bazel issue (bazelbuild/bazel#17158), the recent introduction of `universal_binary` ended up forking the configuration for dependencies of the Jazzer launcher. As a result, some Java targets were built twice and the Docker images failed to build as the Jazzer standalone jar was no longer a dependency of the launcher in the default configuration. As a workaround and also because it prevents similar issues on a more fundamental level, switch to the soon to be default improved config hash algorithm.
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 19, 2023
Resolves a TODO in the code to not unnecessarily fork the configuration when a transition has `--cpu` as a declared output but doesn't change it. Closes #17158. PiperOrigin-RevId: 501021431 Change-Id: Ib942ea9584b2ceb3083b5fec71e2e11b89dcfdb6 Co-authored-by: Fabian Meumertzheim <[email protected]>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Resolves a TODO in the code to not unnecessarily fork the configuration when a transition has `--cpu` as a declared output but doesn't change it. Closes #17158. PiperOrigin-RevId: 501021431 Change-Id: Ib942ea9584b2ceb3083b5fec71e2e11b89dcfdb6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a TODO in the code to not unnecessarily fork the configuration when a transition has
--cpuas a declared output but doesn't change it.