Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set --experimental_action_listeners to default in exec config #16912

Closed
wants to merge 1 commit into from
Closed

Set --experimental_action_listeners to default in exec config #16912

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 3, 2022

Previously, the flag value was set to null rather than an empty list, which resulted in distinct yet equivalent configurations.

Fixes #16911

@fmeum
Set --experimental_action_listeners to default in exec config
0718203 
Previously, the flag value was set to `null` rather than an empty list,
which resulted in distinct yet equivalent configurations.
@fmeum fmeum marked this pull request as ready for review December 3, 2022 10:44
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 3, 2022

@gregestren

@sgowroji sgowroji added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Dec 3, 2022
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 5, 2022
@copybara-service copybara-service bot closed this in 28d2daa Dec 6, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 6, 2022
@fmeum fmeum deleted the 16911-action-listener-default branch December 6, 2022 06:59
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 6, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2022
@eric-skydio
Copy link

Are there plans to backport this to 6.x?

@meteorcloudy
Copy link
Member

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 14, 2022
@bazel-io bazel-io mentioned this pull request Dec 14, 2022
Closed
@ShreeM01 ShreeM01 mentioned this pull request Jan 20, 2023
Merged
ShreeM01 added a commit that referenced this pull request Jan 24, 2023
@ShreeM01 @fmeum
Set --experimental_action_listeners to default in exec config (#1…
4671642 
…7284)

Previously, the flag value was set to `null` rather than an empty list, which resulted in distinct yet equivalent configurations.

Fixes #16911

Closes #16912.

PiperOrigin-RevId: 493175302
Change-Id: I7a34c988265f3a3d94f1720a7fc7ad501eb44247

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregestren gregestren gregestren approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimental_action_listener config variable is set to "null" instead of "[]" in exec configuration
6 participants
@fmeum @eric-skydio @meteorcloudy @gregestren @bazel-io @sgowroji