Emit LLVM coverage for source file paths with a tmp segment
#16852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM LCOV coverage collection logic attempted to filter out source files under `/tmp/`, but instead filtered out all source files with paths containing the substring `/tmp/`. Under macOS, where Bazel's output base lies under `/private/var/tmp`, this matched every output base absolute path.
|
@c-mita Could you review this PR? |
sgowroji
added
team-Rules-Server
|
@c-mita Friendly ping |
|
Hello @c-mita, Can you please confirm to import the above PR changes. |
c-mita
added
awaiting-PR-merge
|
Oops. Yes, this should be imported. |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 26, 2023
The LLVM LCOV coverage collection logic attempted to filter out source files under `/tmp/`, but instead filtered out all source files with paths containing the substring `/tmp/`. Under macOS, where Bazel's output base lies under `/private/var/tmp`, this matched every output base absolute path. Closes #16852. PiperOrigin-RevId: 500973551 Change-Id: I6c890f38c19eedec83cdf0ea99f021eb85f4e697 Co-authored-by: Fabian Meumertzheim <[email protected]>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
The LLVM LCOV coverage collection logic attempted to filter out source files under `/tmp/`, but instead filtered out all source files with paths containing the substring `/tmp/`. Under macOS, where Bazel's output base lies under `/private/var/tmp`, this matched every output base absolute path. Closes #16852. PiperOrigin-RevId: 500973551 Change-Id: I6c890f38c19eedec83cdf0ea99f021eb85f4e697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLVM LCOV coverage collection logic attempted to filter out source files under
/tmp/, but instead filtered out all source files with paths containing the substring/tmp/. Under macOS, where Bazel's output base lies under/private/var/tmp, this matched every output base absolute path.