Fsync before rename after copy in DiskCacheClient #16691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Remote-Exec
coeuvre
approved these changes
Nov 8, 2022
coeuvre
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Nov 23, 2022
Debugging `disk_cache` at work, found this TODO in the code, decided to implement. If `fsync` fails we don't rename to final name — which is the correct error handling as it was before if `copy` failed. Closes bazelbuild#16691. PiperOrigin-RevId: 486901488 Change-Id: Ia2aef6bc196e1d0a61f46b7b6c719563938ff48e
ShreeM01
pushed a commit
that referenced
this pull request
Nov 23, 2022
Debugging `disk_cache` at work, found this TODO in the code, decided to implement. If `fsync` fails we don't rename to final name — which is the correct error handling as it was before if `copy` failed. Closes #16691. PiperOrigin-RevId: 486901488 Change-Id: Ia2aef6bc196e1d0a61f46b7b6c719563938ff48e Co-authored-by: Artem Zinnatullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging
disk_cacheat work, found this TODO in the code, decided to implement.If
fsyncfails we don't rename to final name — which is the correct error handling as it was before ifcopyfailed.