Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redact 'token' strings from logging #16622

Closed
wants to merge 1 commit into from
Closed

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Nov 1, 2022

It's common for users to set 'TOKEN' as an env var. While this is a little like whack-a-mole and we can't cover everything, this seems like a common string to redact.

@sgowroji sgowroji added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Nov 1, 2022
@alexeagle
Copy link
Contributor

alexeagle commented Nov 9, 2022

ping @meisterT ? We have some clients leaking their secrets in Bazel logs right now.

meisterT pushed a commit to meisterT/bazel that referenced this pull request Nov 14, 2022
It's common for users to set 'TOKEN' as an env var. While this is a little like whack-a-mole and we can't cover everything, this seems like a common string to redact.

Closes bazelbuild#16622.

PiperOrigin-RevId: 488392632
Change-Id: I7b48199cc140d6736cd145df63e03eeda747c7fb
(cherry picked from commit 1940c5d)
@meisterT
Copy link
Member

I requested it to be cherry-picked in #16764

ShreeM01 pushed a commit that referenced this pull request Nov 14, 2022
It's common for users to set 'TOKEN' as an env var. While this is a little like whack-a-mole and we can't cover everything, this seems like a common string to redact.

Closes #16622.

PiperOrigin-RevId: 488392632
Change-Id: I7b48199cc140d6736cd145df63e03eeda747c7fb
(cherry picked from commit 1940c5d)

Co-authored-by: Matt Mackay <[email protected]>
@mattem mattem deleted the tokens branch November 19, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants