Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[remote/downloader] Migrate Downloader to take Credentials #16601

Closed
wants to merge 1 commit into from
Closed

[remote/downloader] Migrate Downloader to take Credentials #16601

wants to merge 1 commit into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Oct 28, 2022

Progress on #15856

@sgowroji sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Oct 28, 2022
@Yannic Yannic force-pushed the yannic-downloader-credentials-1 branch from 4c861fc to 2756319 Compare November 2, 2022 15:26
@Yannic Yannic marked this pull request as ready for review November 2, 2022 15:27
@Yannic Yannic requested a review from a team as a code owner November 2, 2022 15:27
@Yannic
Copy link
Contributor Author

Yannic commented Nov 2, 2022

PTAL

tjgq
tjgq approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@tjgq tjgq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing.

I think I'd prefer to put StaticCredentials.java in authandtls instead of creating another subpackage (unless you give me a strong reason not to). Thoughts?

@Yannic
Copy link
Contributor Author

Yannic commented Nov 2, 2022

SGTM

@copybara-service copybara-service bot closed this in c8d445a Nov 3, 2022
Yannic added a commit to EngFlow/bazel that referenced this pull request Nov 10, 2022
@Yannic
[remote/downloader] Migrate Downloader to take Credentials
8ce785d 
Progress on bazelbuild#15856

Closes bazelbuild#16601.

PiperOrigin-RevId: 485837451
Change-Id: I785882d0ff3e171dcaee6aa6f628bca9232c730a
@Yannic Yannic mentioned this pull request Nov 10, 2022
Merged
meteorcloudy pushed a commit that referenced this pull request Nov 10, 2022
@Yannic
[remote/downloader] Migrate Downloader to take Credentials (#16732)
38c5019 
Progress on #15856

Closes #16601.

PiperOrigin-RevId: 485837451
Change-Id: I785882d0ff3e171dcaee6aa6f628bca9232c730a
lripoche pushed a commit to lripoche/bazel that referenced this pull request Jun 13, 2023
@Yannic
[remote/downloader] Migrate Downloader to take Credentials
3a1035d 
Progress on bazelbuild#15856

Closes bazelbuild#16601.

PiperOrigin-RevId: 485837451
Change-Id: I785882d0ff3e171dcaee6aa6f628bca9232c730a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yannic @tjgq @sgowroji